From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/8] Clean up CONFIG_SYS_{CBSIZE, PBSIZE, MAXARGS, BARGSIZE} definitions
Date: Thu, 24 Aug 2017 21:13:32 +0200 [thread overview]
Message-ID: <20170824211332.7a6d7aea@windsurf> (raw)
In-Reply-To: <20170824185335.DF1F31202C3@gemini.denx.de>
Hello,
On Thu, 24 Aug 2017 20:53:35 +0200, Wolfgang Denk wrote:
> > I believe this patch series is a step in that direction. With this
> > patch series applied, we can now clearly identify which boards have
> > custom values for CONFIG_SYS_{CBSIZE, PBSIZE, MAXARGS, BARGSIZE}, and
> > therefore more easily move these from the .h files to defconfig files.
>
> So you think moving this to Kconfig would be a second step? Ok,
> fine with me.
Yes, this would be a second step. The current patch series eliminates
the situations where the .h files use the default values, or values
that are close enough to the default values for the default value to
remain reasonable.
Of course, the patches should be reviewed, and the decision taken by
them potentially discussed.
> > The choice for such values is totally independent from the HW, but
> > rather tied to the specific use of a given board. For the same board,
>
> No, it is not. Buffer sizes eat on RAM, and there are environments
> (like today in SPL) where this may be a precious resource.
Right, true.
> > most people will find the default value to be OK, some people will need
> > a larger number of command arguments or a bigger Linux kernel command
> > line.
> >
> > Let me know what your preference is.
>
> I think it makes a lot of sense to keep such configuration parameters
> changable, but we hould not stop half way but rather move this to
> Kconfig so it's easy to use a default setting, and only boards with
> special needs have to adjust this in their defconfig files.
OK. So let's review this first patch series. Once we agree on it and it
gets merged, I can work on the second step of moving those
configuration options to Kconfig.
Thanks for the very useful feedback!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-08-24 19:13 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 20:58 [U-Boot] [PATCH 0/8] Clean up CONFIG_SYS_{CBSIZE, PBSIZE, MAXARGS, BARGSIZE} definitions Thomas Petazzoni
2017-08-23 20:58 ` [U-Boot] [PATCH 1/8] include/config_fallbacks.h: add default for CONFIG_SYS_CBSIZE Thomas Petazzoni
2017-08-25 1:12 ` Tom Rini
2017-09-04 0:41 ` [U-Boot] [U-Boot, " Tom Rini
2017-08-23 20:59 ` [U-Boot] [PATCH 2/8] include/configs: remove CONFIG_SYS_CBSIZE when the default value is used Thomas Petazzoni
2017-08-25 1:11 ` Tom Rini
2017-09-04 0:41 ` [U-Boot] [U-Boot, " Tom Rini
2017-08-23 20:59 ` [U-Boot] [PATCH 3/8] include/config_fallbacks.h: change fallback for CONFIG_SYS_PBSIZE Thomas Petazzoni
2017-08-25 1:11 ` Tom Rini
2017-09-04 0:41 ` [U-Boot] [U-Boot, " Tom Rini
2017-08-23 20:59 ` [U-Boot] [PATCH 4/8] include/configs: drop default definitions of CONFIG_SYS_PBSIZE Thomas Petazzoni
2017-08-25 1:11 ` Tom Rini
2017-09-04 0:41 ` [U-Boot] [U-Boot, " Tom Rini
2017-08-23 20:59 ` [U-Boot] [PATCH 5/8] include/config_fallbacks.h: add default for CONFIG_SYS_MAXARGS Thomas Petazzoni
2017-08-25 1:12 ` Tom Rini
2017-09-04 0:41 ` [U-Boot] [U-Boot, " Tom Rini
2017-08-23 20:59 ` [U-Boot] [PATCH 6/8] include/configs: drop default definitions of CONFIG_SYS_MAXARGS Thomas Petazzoni
2017-08-25 1:12 ` Tom Rini
2017-09-04 0:41 ` [U-Boot] [U-Boot, " Tom Rini
2017-08-23 20:59 ` [U-Boot] [PATCH 7/8] include/configs: remove default values of CONFIG_SYS_BARGSIZE Thomas Petazzoni
2017-08-25 1:12 ` Tom Rini
2017-09-04 0:41 ` [U-Boot] [U-Boot, " Tom Rini
2017-08-23 20:59 ` [U-Boot] [PATCH 8/8] include/configs: remove numerous CONFIG_SYS_BARGSIZE definitions Thomas Petazzoni
2017-08-25 1:12 ` Tom Rini
2017-09-04 0:42 ` [U-Boot] [U-Boot, " Tom Rini
2017-08-24 8:05 ` [U-Boot] [PATCH 0/8] Clean up CONFIG_SYS_{CBSIZE, PBSIZE, MAXARGS, BARGSIZE} definitions Chris Packham
2017-08-24 10:16 ` Wolfgang Denk
2017-08-24 14:23 ` Thomas Petazzoni
2017-08-24 18:53 ` Wolfgang Denk
2017-08-24 19:13 ` Thomas Petazzoni [this message]
2017-08-25 11:31 ` Dr. Philipp Tomsich
2017-08-25 1:12 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170824211332.7a6d7aea@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox