[U-Boot] [PATCH 0/8] Clean up CONFIG_SYS_{CBSIZE, PBSIZE, MAXARGS, BARGSIZE} definitions

Tom Rini
2017-08-25T01:12:19Z

On Thu, Aug 24, 2017 at 04:23:18PM +0200, Thomas Petazzoni wrote:
> Hello,
>
> On Thu, 24 Aug 2017 12:16:30 +0200, Wolfgang Denk wrote:
>
> > > In this patch series, I propose to have U-Boot define some sane
> > > defaults for those 4 configuration options, and cleanup all the board
> > > configuration files that were using the default values. This leads to
> > > the removal of 1300+ lines.
> >
> > Would it not be even easier (and less code) to move these
> > definitions to Kconfig settings?
>
> I believe this patch series is a step in that direction. With this
> patch series applied, we can now clearly identify which boards have
> custom values for CONFIG_SYS_{CBSIZE, PBSIZE, MAXARGS, BARGSIZE}, and
> therefore more easily move these from the .h files to defconfig files.
>
> Unless of course we decide that having such custom values
> in .h/defconfig is useless, and we want to drop them entirely. As I
> said in my cover letter, I really don't see why a board configuration
> file (be it a .h or a defconfig) should specify the maximum number of
> command arguments or the maximum size of the Linux kernel command line.
> The choice for such values is totally independent from the HW, but
> rather tied to the specific use of a given board. For the same board,
> most people will find the default value to be OK, some people will need
> a larger number of command arguments or a bigger Linux kernel command
> line.
>
> Let me know what your preference is.

Thanks for doing this. What I think we should do is migrate these to
Kconfig with the fallback values as the 'vanilla' default and use
moveconfig.py -I min2 to see if there's other cases where it's a SoC
thing or similar where other non-default small values were used in order
to reduce the overall footprint.

--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170824/485d1a9c/attachment.sig>