From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] env: Fix operation of 'make environ'
Date: Mon, 28 Aug 2017 07:13:43 -0400 [thread overview]
Message-ID: <20170828111343.GD17058@bill-the-cat> (raw)
In-Reply-To: <yw1x8ti43qhs.fsf@mansr.com>
On Mon, Aug 28, 2017 at 12:01:51PM +0100, M책ns Rullg책rd wrote:
> Simon Glass <sjg@chromium.org> writes:
>
> > This was broken by the recent environment refactoring. Specifically:
> >
> > $ make environ
> > scripts/Makefile.build:59: tools/environ/Makefile: No such file or directory
> > make[1]: *** No rule to make target 'tools/environ/Makefile'. Stop.
> > make: *** [Makefile:1469: environ] Error 2
> >
> > Fix this by updating the Makefile and adjusting the #include filesnames in
> > two C files.
> >
> > Fixes: ec74f5f (Makefile: Rename 'env' target to 'environ')
> > Reported-by: M책ns Rullg책rd <mans@mansr.com>
> > Signed-off-by: Simon Glass <sjg@chromium.org>
>
> This still breaks any build scripts using the old target (yes, there are
> many). That's probably acceptable, but a mention of it in some release
> note would be nice.
>
> Come to think of it, if we're anyway going to break things, how about
> giving that target a more descriptive name than environ? I suggest
> envtools.
Too early, no coffee. Can't we do some make logic so that 'env' is
still a target and thus we don't break those scripts? Otherwise, yes,
I'll make sure to indicate in at least the v2017.09 release email that
we renamed 'env' to envtools or something. Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170828/22ddbc2a/attachment.sig>
next prev parent reply other threads:[~2017-08-28 11:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-27 16:48 [U-Boot] [PATCH] env: Fix operation of 'make environ' Simon Glass
2017-08-28 11:01 ` Måns Rullgård
2017-08-28 11:13 ` Tom Rini [this message]
2017-08-28 16:08 ` Joe Hershberger
2017-09-05 7:54 ` Simon Glass
-- strict thread matches above, loose matches on Subject: below --
2017-08-29 19:53 Simon Glass
2017-08-29 20:02 ` Joe Hershberger
2017-08-29 20:16 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170828111343.GD17058@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox