public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] video: ipuv3_fb: skip IPU shutdown if IPU was not enabled before
Date: Mon, 28 Aug 2017 20:23:12 +0200	[thread overview]
Message-ID: <20170828202312.3f7e3ec7@crub> (raw)
In-Reply-To: <1d1ff220-f225-7d32-061f-6b9c738a52bf@denx.de>

Hi Stefano,

On Mon, 28 Aug 2017 18:54:39 +0200
Stefano Babic sbabic at denx.de wrote:
...
> > +	/*
> > +	 * Check if IPU clock was enabled before. Won't access
> > +	 * IPU registers if clock is not enabled.
> > +	 */
> > +	reg = readl(&mxc_ccm->CCGR3);
> > +	if ((reg & MXC_CCM_CCGR3_IPU1_IPU_MASK) == 0)
> > +		return;
> >    
> 
> It looks to me quite weak to simply check if clock is gated. On some
> board clock is gated even if IPU is not active. Do you have a way
> reading inside IPU itself ? Then we can better decide if it was really
> acrive. For example, checking if ipu_enable_channel() was called (and
> DMA registers are set).

we cannot access IPU registers when IPU clock is disabled (register
access will hang the CPU).

Thanks,
Anatolij

      reply	other threads:[~2017-08-28 18:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-25 13:10 [U-Boot] [PATCH] video: ipuv3_fb: skip IPU shutdown if IPU was not enabled before Anatolij Gustschin
2017-08-28 16:22 ` Fabio Estevam
2017-08-28 18:08   ` Anatolij Gustschin
2017-08-28 16:54 ` Stefano Babic
2017-08-28 18:23   ` Anatolij Gustschin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170828202312.3f7e3ec7@crub \
    --to=agust@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox