public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [UBOOT] [PATCH] cmd: usb: ignore block devices under mass storage device
Date: Fri, 1 Sep 2017 08:30:49 +0200	[thread overview]
Message-ID: <20170901083049.32ed8295@karo-electronics.de> (raw)
In-Reply-To: <1502430811-21475-1-git-send-email-suneelglinux@gmail.com>

Hi,

On Thu, 10 Aug 2017 22:53:31 -0700 Suneel Garapati wrote:
> usb tree and info commands may cause crash otherwise
> 
> Signed-off-by: Suneel Garapati <suneelglinux@gmail.com>
> ---
>  cmd/usb.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/cmd/usb.c b/cmd/usb.c
> index 992d414..81e1a7b 100644
> --- a/cmd/usb.c
> +++ b/cmd/usb.c
> @@ -415,7 +415,8 @@ static void usb_show_tree_graph(struct usb_device *dev, char *pre)
>  		udev = dev_get_parent_priv(child);
>  
>  		/* Ignore emulators, we only want real devices */
> -		if (device_get_uclass_id(child) != UCLASS_USB_EMUL) {
> +		if (device_get_uclass_id(child) !=
> +		    (UCLASS_USB_EMUL | UCLASS_BLK)) {
>
This should most probably be:
> +		if ((device_get_uclass_id(child) != UCLASS_USB_EMUL) &&
			(device_get_uclass_id(child) != UCLASS_BLK)) {


Lothar Waßmann

  parent reply	other threads:[~2017-09-01  6:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-11  5:53 [U-Boot] [UBOOT] [PATCH] cmd: usb: ignore block devices under mass storage device Suneel Garapati
2017-08-13 21:37 ` Simon Glass
2017-08-15  3:06   ` Suneel Garapati
2017-08-28 18:37     ` Suneel Garapati
2017-08-31 12:52     ` Simon Glass
2017-09-01  7:34       ` Suneel Garapati
2017-09-01  6:30 ` Lothar Waßmann [this message]
2017-09-01  7:35   ` Suneel Garapati

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170901083049.32ed8295@karo-electronics.de \
    --to=lw@karo-electronics.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox