public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Peng Fan <van.freenix@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] video: ipu_common: fix build error
Date: Wed, 6 Sep 2017 09:16:22 +0800	[thread overview]
Message-ID: <20170906011619.GA12592@linux-7smt.suse> (raw)
In-Reply-To: <7275421f-e4b0-0be4-a856-b9b4159b6845@cox.net>

Hi Eric,
On Mon, Sep 04, 2017 at 07:48:56PM -0700, Eric Nelson wrote:
>Hi Peng,
>
>Can you tell that I'm hunting a bug in an old version?
>
>I'm seeing a **very** intermittent regression between U-Boot
>versions 2015.07 and 2016.05 and happened to spot something
>in this patch.
>
>On 04/27/2016 07:07 PM, Peng Fan wrote:
>>Some toolchains fail to build
>>"clk->rate = (u64)(clk->parent->rate * 16) / div;"
>>And the cast usage is wrong.
>>
>>Use the following code to fix the issue,
>>"
>>   do_div(parent_rate, div);
>>   clk->rate = parent_rate;
>>"
>>
>>Reported-by: Peter Robinson <pbrobinson@gmail.com>
>>Signed-off-by: Peng Fan <van.freenix@gmail.com>
>>Cc: Stefano Babic <sbabic@denx.de>
>>Cc: Fabio Estevam <fabio.estevam@nxp.com>
>>Cc: Tom Rini <trini@konsulko.com>
>>Cc: Anatolij Gustschin <agust@denx.de>
>>Cc: Peter Robinson <pbrobinson@gmail.com>
>>Reviewed-by: Tom Rini <trini@konsulko.com>
>>Tested-by: Peter Robinson <pbrobinson@gmail.com>
>>---
>>
>>Hi Peter,
>>
>>  Please help test this patch to see whether this fix your issue or not.
>>  Thanks for pointing out this issue.
>>
>>Thanks,
>>Peng.
>>
>>  drivers/video/ipu_common.c | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>>diff --git a/drivers/video/ipu_common.c b/drivers/video/ipu_common.c
>>index 36d4b23..5676a0f 100644
>>--- a/drivers/video/ipu_common.c
>>+++ b/drivers/video/ipu_common.c
>>@@ -352,7 +352,9 @@ static int ipu_pixel_clk_set_rate(struct clk *clk, unsigned long rate)
>>  	 */
>>  	__raw_writel((div / 16) << 16, DI_BS_CLKGEN1(clk->id));
>
>Did we lose a multiply by 16 in this change?

We already have "parent_rate = (unsigned long long)clk->parent->rate * 16;"
in this function.

Thanks,
Peng.

>
>>-	clk->rate = (u64)(clk->parent->rate * 16) / div;
>>+	do_div(parent_rate, div);
>>+
>>+	clk->rate = parent_rate;
>>  	return 0;
>>  }
>>
>
>Please advise,
>
>
>Eric

  reply	other threads:[~2017-09-06  1:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-28  2:07 [U-Boot] [PATCH] video: ipu_common: fix build error Peng Fan
2016-04-28 12:52 ` Tom Rini
2016-04-28 14:20 ` Peter Robinson
2016-04-28 14:29   ` Stefano Babic
2016-04-28 14:44     ` Anatolij Gustschin
2017-09-05  2:48 ` [U-Boot] " Eric Nelson
2017-09-06  1:16   ` Peng Fan [this message]
2017-09-06 17:34     ` Eric Nelson
2017-09-07  6:01       ` Lothar Waßmann
2017-09-07  7:23         ` Eric Nelson
2017-09-05  2:49 ` Eric Nelson
2017-09-05 13:33   ` Fabio Estevam
2017-09-05 13:56     ` Eric Nelson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170906011619.GA12592@linux-7smt.suse \
    --to=van.freenix@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox