[U-Boot] [U-Boot, 1/1] add pytests for 'gpt rename' and 'gpt swap'

Tom Rini
2017-09-15T16:16:44Z

On Fri, Sep 15, 2017 at 09:40:29AM -0600, Stephen Warren wrote:
> On 09/15/2017 06:29 AM, Tom Rini wrote:
> >On Sat, Sep 09, 2017 at 11:54:51PM -0700, alison at peloton-tech.com wrote:
> >>From: Alison Chaiken <alison@peloton-tech.com>
> >>
> >>Add unit tests for the 'gpt rename' and 'gpt swap' commands that
> >>rely on the block device created by test/py/make_test_disk.py.
> >>Add CONFIG_CMD_GPT_RENAME to the sandbox_defconfig. Remove the
> >>testdisk.raw test device at the end of the tests.
> >>
> >>Signed-off-by: Alison Chaiken <alison@peloton-tech.com>
> >>Reviewed-by: Simon Glass <sjg@chromium.org>
> >
> >Applied to u-boot/master, thanks!
>
> As of commit cd3e8a72a6fb "test/py: u_boot_console_base.py: fix
> typo", in u-boot/master, test/py is failing test_gpt_*, with the log
> below. I assume that's due to this commit, since it relates to GPT,
> but I haven't bisected.
>
> => host bind 0 testdisk.raw
> Failed to access host backing file 'testdisk.raw'
> exit not allowed from main input shell.
> => gpt guid host 0
> do_gpt: host dev 0 NOT available
> =>
>
> FAILED:
> u_boot_console = <u_boot_console_sandbox.ConsoleSandbox object at
> 0x7f60875a7e10>
>
> @pytest.mark.buildconfigspec('cmd_gpt')
> def test_gpt_guid(u_boot_console):
> """Test the gpt guid command."""
>
> if u_boot_console.config.buildconfig.get('config_cmd_gpt',
> 'n') != 'y':
> pytest.skip('gpt command not supported')
> make_test_disk.makeDisk()
> u_boot_console.run_command('host bind 0 testdisk.raw')
> output = u_boot_console.run_command('gpt guid host 0')
> > assert '375a56f7-d6c9-4e81-b5f0-09d41ca89efe' in output
> E assert '375a56f7-d6c9-4e81-b5f0-09d41ca89efe' in 'do_gpt:
> host dev 0 NOT available'
>
> src/u-boot/test/py/tests/test_gpt.py:26: AssertionError

The "good" news is that it's not something blatantly wrong in the test,
it runs for me and in travis as well.

--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170915/479cfc5a/attachment.sig>