public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Rob Clark <robdclark@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 06/21] efi_loader: drop redundant efi_device_path_protocol
Date: Sun, 10 Sep 2017 07:21:28 -0400	[thread overview]
Message-ID: <20170910112149.21358-12-robdclark@gmail.com> (raw)
In-Reply-To: <20170910112149.21358-1-robdclark@gmail.com>

This is really the same thing as the efi_device_path struct.

Signed-off-by: Rob Clark <robdclark@gmail.com>
---
 include/efi_api.h                        | 12 ++----------
 lib/efi_loader/efi_device_path_to_text.c | 13 ++++++++-----
 2 files changed, 10 insertions(+), 15 deletions(-)

diff --git a/include/efi_api.h b/include/efi_api.h
index 4e27c82129..ac58fd58de 100644
--- a/include/efi_api.h
+++ b/include/efi_api.h
@@ -487,22 +487,14 @@ struct efi_console_control_protocol
 	EFI_GUID(0x8b843e20, 0x8132, 0x4852, \
 		 0x90, 0xcc, 0x55, 0x1a, 0x4e, 0x4a, 0x7f, 0x1c)
 
-struct efi_device_path_protocol
-{
-	uint8_t type;
-	uint8_t sub_type;
-	uint16_t length;
-	uint8_t data[];
-};
-
 struct efi_device_path_to_text_protocol
 {
 	uint16_t *(EFIAPI *convert_device_node_to_text)(
-			struct efi_device_path_protocol *device_node,
+			struct efi_device_path *device_node,
 			bool display_only,
 			bool allow_shortcuts);
 	uint16_t *(EFIAPI *convert_device_path_to_text)(
-			struct efi_device_path_protocol *device_path,
+			struct efi_device_path *device_path,
 			bool display_only,
 			bool allow_shortcuts);
 };
diff --git a/lib/efi_loader/efi_device_path_to_text.c b/lib/efi_loader/efi_device_path_to_text.c
index 4b2f43f0c8..f9d071ac50 100644
--- a/lib/efi_loader/efi_device_path_to_text.c
+++ b/lib/efi_loader/efi_device_path_to_text.c
@@ -16,7 +16,7 @@ const efi_guid_t efi_guid_device_path_to_text_protocol =
 		EFI_DEVICE_PATH_TO_TEXT_PROTOCOL_GUID;
 
 static uint16_t *efi_convert_device_node_to_text(
-		struct efi_device_path_protocol *device_node,
+		struct efi_device_path *device_node,
 		bool display_only,
 		bool allow_shortcuts)
 {
@@ -55,15 +55,18 @@ static uint16_t *efi_convert_device_node_to_text(
 		break;
 	case DEVICE_PATH_TYPE_MEDIA_DEVICE:
 		switch (device_node->sub_type) {
-		case DEVICE_PATH_SUB_TYPE_FILE_PATH:
+		case DEVICE_PATH_SUB_TYPE_FILE_PATH: {
+			struct efi_device_path_file_path *fp =
+				(struct efi_device_path_file_path *)device_node;
 			buffer_size = device_node->length - 4;
 			r = efi_allocate_pool(EFI_ALLOCATE_ANY_PAGES,
 					      buffer_size, (void **) &buffer);
 			if (r != EFI_SUCCESS)
 				return NULL;
-			memcpy(buffer, device_node->data, buffer_size);
+			memcpy(buffer, fp->str, buffer_size);
 			break;
 		}
+		}
 		break;
 	}
 
@@ -89,7 +92,7 @@ static uint16_t *efi_convert_device_node_to_text(
 }
 
 static uint16_t EFIAPI *efi_convert_device_node_to_text_ext(
-		struct efi_device_path_protocol *device_node,
+		struct efi_device_path *device_node,
 		bool display_only,
 		bool allow_shortcuts)
 {
@@ -105,7 +108,7 @@ static uint16_t EFIAPI *efi_convert_device_node_to_text_ext(
 }
 
 static uint16_t EFIAPI *efi_convert_device_path_to_text(
-		struct efi_device_path_protocol *device_path,
+		struct efi_device_path *device_path,
 		bool display_only,
 		bool allow_shortcuts)
 {
-- 
2.13.5

  parent reply	other threads:[~2017-09-10 11:21 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-10 11:21 [U-Boot] [PATCH v2 00/21] efi_loader: enough UEFI for standard distro boot Rob Clark
2017-09-10 11:21 ` [U-Boot] [PATCH v3 1/9] fs/fat: split out helper to init fsdata Rob Clark
2017-09-10 11:21 ` [U-Boot] [PATCH v2 01/21] part: move efi_guid_t Rob Clark
2017-09-11 22:55   ` Heinrich Schuchardt
2017-09-12 12:29   ` Simon Glass
2017-09-10 11:21 ` [U-Boot] [PATCH v3 2/9] fs/fat: introduce new director iterators Rob Clark
2017-09-12 12:29   ` Simon Glass
2017-09-10 11:21 ` [U-Boot] [PATCH v2 02/21] part: extract MBR signature from partitions Rob Clark
2017-09-12 12:29   ` Simon Glass
2017-09-10 11:21 ` [U-Boot] [PATCH v2 03/21] efi: add some missing __packed Rob Clark
2017-09-12 12:30   ` Simon Glass
2017-09-10 11:21 ` [U-Boot] [PATCH v3 3/9] fat/fs: convert to directory iterators Rob Clark
2017-09-10 11:21 ` [U-Boot] [PATCH v2 04/21] efi: add some more device path structures Rob Clark
2017-09-12 12:30   ` Simon Glass
2017-09-10 11:21 ` [U-Boot] [PATCH v3 4/9] fs: add fs_readdir() Rob Clark
2017-09-10 11:21 ` [U-Boot] [PATCH v2 05/21] efi_loader: add device-path utils Rob Clark
2017-09-12 12:30   ` Simon Glass
2017-09-12 13:05     ` Rob Clark
2017-09-10 11:21 ` [U-Boot] [PATCH v3 5/9] fs/fat: implement opendir/readdir/closedir Rob Clark
2017-09-10 11:21 ` Rob Clark [this message]
2017-09-10 11:21 ` [U-Boot] [PATCH v3 6/9] fat/fs: remove a bunch of dead code Rob Clark
2017-09-10 11:21 ` [U-Boot] [PATCH v2 07/21] efi_loader: flesh out device-path to text Rob Clark
2017-09-10 11:21 ` [U-Boot] [PATCH v3 7/9] fat/fs: move ls to generic implementation Rob Clark
2017-09-10 11:21 ` [U-Boot] [PATCH v2 08/21] efi_loader: use proper device-paths for partitions Rob Clark
2017-09-10 11:21 ` [U-Boot] [PATCH v3 8/9] fs/fat: fix case for FAT shortnames Rob Clark
2017-09-10 11:21 ` [U-Boot] [PATCH v2 09/21] efi_loader: use proper device-paths for net Rob Clark
2017-09-10 11:21 ` [U-Boot] [PATCH v3 9/9] fs/fat: Clean up open-coded sector <-> cluster conversions Rob Clark
2017-09-10 11:21 ` [U-Boot] [PATCH v2 10/21] efi_loader: refactor boot device and loaded_image handling Rob Clark
2017-09-10 11:21 ` [U-Boot] [PATCH v2 11/21] efi_loader: add file/filesys support Rob Clark
2017-09-12 12:30   ` Simon Glass
2017-09-10 11:21 ` [U-Boot] [PATCH v2 12/21] efi_loader: support load_image() from a file-path Rob Clark
2017-09-10 11:21 ` [U-Boot] [PATCH v2 13/21] efi_loader: make pool allocations cacheline aligned Rob Clark
2017-09-10 11:21 ` [U-Boot] [PATCH v2 14/21] efi_loader: efi variable support Rob Clark
2017-09-12 12:30   ` Simon Glass
2017-09-12 13:10     ` Rob Clark
2017-09-10 11:21 ` [U-Boot] [PATCH v2 15/21] efi_loader: add bootmgr Rob Clark
2017-09-12 12:30   ` Simon Glass
2017-09-10 11:21 ` [U-Boot] [PATCH v2 16/21] efi_loader: file_path should be variable length Rob Clark
2017-09-10 11:21 ` [U-Boot] [PATCH v2 17/21] efi_loader: set loaded image code/data type properly Rob Clark
2017-09-10 11:21 ` [U-Boot] [PATCH v2 18/21] efi_loader: print GUIDs Rob Clark
2017-09-10 11:21 ` [U-Boot] [PATCH v2 19/21] efi_loader: split out escape sequence based size query Rob Clark
2017-09-10 11:21 ` [U-Boot] [PATCH v2 20/21] efi_loader: Correctly figure out size for vidconsole Rob Clark
2017-09-10 11:21 ` [U-Boot] [PATCH v2 21/21] efi_loader: Some console improvements " Rob Clark
2017-09-12 12:30   ` Simon Glass
2017-09-10 11:38 ` [U-Boot] [PATCH v2 00/21] efi_loader: enough UEFI for standard distro boot Rob Clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170910112149.21358-12-robdclark@gmail.com \
    --to=robdclark@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox