From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, 1/1] add pytests for 'gpt rename' and 'gpt swap'
Date: Fri, 15 Sep 2017 12:16:44 -0400 [thread overview]
Message-ID: <20170915161644.GH4560@bill-the-cat> (raw)
In-Reply-To: <58e7920a-1113-b8db-489d-8530b8e48c4d@wwwdotorg.org>
On Fri, Sep 15, 2017 at 09:40:29AM -0600, Stephen Warren wrote:
> On 09/15/2017 06:29 AM, Tom Rini wrote:
> >On Sat, Sep 09, 2017 at 11:54:51PM -0700, alison at peloton-tech.com wrote:
> >>From: Alison Chaiken <alison@peloton-tech.com>
> >>
> >>Add unit tests for the 'gpt rename' and 'gpt swap' commands that
> >>rely on the block device created by test/py/make_test_disk.py.
> >>Add CONFIG_CMD_GPT_RENAME to the sandbox_defconfig. Remove the
> >>testdisk.raw test device at the end of the tests.
> >>
> >>Signed-off-by: Alison Chaiken <alison@peloton-tech.com>
> >>Reviewed-by: Simon Glass <sjg@chromium.org>
> >
> >Applied to u-boot/master, thanks!
>
> As of commit cd3e8a72a6fb "test/py: u_boot_console_base.py: fix
> typo", in u-boot/master, test/py is failing test_gpt_*, with the log
> below. I assume that's due to this commit, since it relates to GPT,
> but I haven't bisected.
>
> => host bind 0 testdisk.raw
> Failed to access host backing file 'testdisk.raw'
> exit not allowed from main input shell.
> => gpt guid host 0
> do_gpt: host dev 0 NOT available
> =>
>
> FAILED:
> u_boot_console = <u_boot_console_sandbox.ConsoleSandbox object at
> 0x7f60875a7e10>
>
> @pytest.mark.buildconfigspec('cmd_gpt')
> def test_gpt_guid(u_boot_console):
> """Test the gpt guid command."""
>
> if u_boot_console.config.buildconfig.get('config_cmd_gpt',
> 'n') != 'y':
> pytest.skip('gpt command not supported')
> make_test_disk.makeDisk()
> u_boot_console.run_command('host bind 0 testdisk.raw')
> output = u_boot_console.run_command('gpt guid host 0')
> > assert '375a56f7-d6c9-4e81-b5f0-09d41ca89efe' in output
> E assert '375a56f7-d6c9-4e81-b5f0-09d41ca89efe' in 'do_gpt:
> host dev 0 NOT available'
>
> src/u-boot/test/py/tests/test_gpt.py:26: AssertionError
The "good" news is that it's not something blatantly wrong in the test,
it runs for me and in travis as well.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170915/479cfc5a/attachment.sig>
next prev parent reply other threads:[~2017-09-15 16:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-03 0:18 [U-Boot] [PATCH 1/3] GPT: create block device for sandbox testing alison at peloton-tech.com
2017-09-03 0:18 ` [U-Boot] [PATCH 2/3] add pytest for 'gpt guid' command in sandbox alison at peloton-tech.com
2017-09-03 0:18 ` [U-Boot] [PATCH 3/3] add pytests for 'gpt rename' and 'gpt swap' alison at peloton-tech.com
2017-09-05 8:55 ` Simon Glass
2017-09-10 6:54 ` [U-Boot] [PATCH v2 1/3] " alison at peloton-tech.com
2017-09-10 6:54 ` [U-Boot] [PATCH 1/1] " alison at peloton-tech.com
2017-09-12 12:29 ` Simon Glass
2017-09-15 12:29 ` [U-Boot] [U-Boot, " Tom Rini
2017-09-15 15:40 ` Stephen Warren
2017-09-15 16:16 ` Tom Rini [this message]
2017-09-15 16:29 ` Stephen Warren
2017-09-05 8:55 ` [U-Boot] [PATCH 1/3] GPT: create block device for sandbox testing Simon Glass
2017-09-10 6:47 ` [U-Boot] [PATCH 0/2] GPT: create block device for guid testing alison at peloton-tech.com
2017-09-10 6:47 ` [U-Boot] [PATCH 1/2] GPT: create block device for sandbox testing alison at peloton-tech.com
2017-09-12 12:29 ` Simon Glass
2017-09-15 12:23 ` [U-Boot] [U-Boot, " Tom Rini
2017-09-10 6:47 ` [U-Boot] [PATCH 2/2] add pytests for 'gpt guid' command in sandbox alison at peloton-tech.com
2017-09-12 12:29 ` Simon Glass
2017-09-15 12:28 ` [U-Boot] [U-Boot, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170915161644.GH4560@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox