[U-Boot] [U-Boot, v3, 3/9] fat/fs: convert to directory iterators

public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed

From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, v3, 3/9] fat/fs: convert to directory iterators
Date: Sun, 17 Sep 2017 09:28:55 -0400	[thread overview]
Message-ID: <20170917132855.GG4560@bill-the-cat> (raw)
In-Reply-To: <CAF6AEGt8SEpkFQ85Yn0GyMHDmZhSmx1fRWeb1_5Rgb9Nnwb-tw@mail.gmail.com>

On Sun, Sep 17, 2017 at 08:53:23AM -0400, Rob Clark wrote:
> On Sun, Sep 17, 2017 at 7:08 AM, Adam Ford <aford173@gmail.com> wrote:
> >
> > Adding the debug to master made no difference.  No debug messages appeared.
> > Interestingly enough, some junk appeard, and the name of U-Boot name
> > wasn't correctly displayed:
> >
> > **SÈ™017.09-00178-g08cebee-dirty (Sep 17 2017 - 06:01:07)
> > Trying to boot from MMC1
> >
> > (hang)
> >
> 
> hmm, one thing I noticed in doc/README.SPL:
> 
> "When building SPL with DEBUG set you may also need to set CONFIG_PANIC_HANG
> as in most cases do_reset is not defined within SPL."
> 
> not sure if that would help.
> 
> Also, it has a section about estimating stack usage.. not sure if this
> implies that stack size is constrained in spl?  If so, maybe that is
> related.  The new directory iterators do move the buffer for current
> block of dir_entry's to the stack.  Reducing
> CONFIG_FS_FAT_MAX_CLUSTSIZE might help.

Yes, in SPL we don't require stack being in SDRAM and unless SPL_STACK_R
is set we have a very limited stack available.  And that looks to be the
common thread between functional and non-functional platforms.  In the
case of what Adam and I both have, we could move to SPL_STACK_R easily
enough.  What needs to be done next 'tho would be to see if making
SPL_FAT_SUPPORT depend on SPL_STACK_R, migrating the various TI
platforms (and possibly others) that could butdon't use SPL_STACK_R, and
seeing if we have platforms that have now lost FAT support.

Or, how hard would it be to make that code not use the stack so much?

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170917/d0f21981/attachment.sig>

next prev parent reply	other threads:[~2017-09-17 13:28 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-09 17:15 [U-Boot] [PATCH v3 0/9] fs/fat: cleanups + readdir implementation Rob Clark
2017-09-09 17:15 ` [U-Boot] [PATCH v3 1/9] fs/fat: split out helper to init fsdata Rob Clark
2017-09-16  2:31   ` [U-Boot] [U-Boot, v3, " Tom Rini
2017-09-09 17:15 ` [U-Boot] [PATCH v3 2/9] fs/fat: introduce new director iterators Rob Clark
2017-09-16  2:32   ` [U-Boot] [U-Boot, v3, " Tom Rini
2017-09-09 17:15 ` [U-Boot] [PATCH v3 3/9] fat/fs: convert to directory iterators Rob Clark
2017-09-12 12:29   ` Simon Glass
2017-09-16  2:32   ` [U-Boot] [U-Boot, v3, " Tom Rini
2017-09-16 20:32     ` Adam Ford
2017-09-16 20:42       ` Rob Clark
2017-09-17 11:08         ` Adam Ford
2017-09-17 12:28           ` Rob Clark
2017-09-17 12:30             ` Rob Clark
2017-09-17 12:53           ` Rob Clark
2017-09-17 13:28             ` Tom Rini [this message]
2017-09-17 13:42             ` Adam Ford
2017-09-17 13:50               ` Rob Clark
2017-09-17 13:52                 ` Adam Ford
2017-09-09 17:15 ` [U-Boot] [PATCH v3 4/9] fs: add fs_readdir() Rob Clark
2017-09-12 12:29   ` Simon Glass
2017-09-16  2:32   ` [U-Boot] [U-Boot,v3,4/9] " Tom Rini
2017-09-09 17:15 ` [U-Boot] [PATCH v3 5/9] fs/fat: implement opendir/readdir/closedir Rob Clark
2017-09-12 12:29   ` Simon Glass
2017-09-16  2:32   ` [U-Boot] [U-Boot, v3, " Tom Rini
2017-09-09 17:15 ` [U-Boot] [PATCH v3 6/9] fat/fs: remove a bunch of dead code Rob Clark
2017-09-16  2:32   ` [U-Boot] [U-Boot,v3,6/9] " Tom Rini
2017-09-09 17:15 ` [U-Boot] [PATCH v3 7/9] fat/fs: move ls to generic implementation Rob Clark
2017-09-16  2:32   ` [U-Boot] [U-Boot, v3, " Tom Rini
2017-09-09 17:15 ` [U-Boot] [PATCH v3 8/9] fs/fat: fix case for FAT shortnames Rob Clark
2017-09-12 12:29   ` Simon Glass
2017-09-16  2:32   ` [U-Boot] [U-Boot,v3,8/9] " Tom Rini
2017-09-09 17:16 ` [U-Boot] [PATCH v3 9/9] fs/fat: Clean up open-coded sector <-> cluster conversions Rob Clark
2017-09-12 12:29   ` Simon Glass
2017-09-16  2:32   ` [U-Boot] [U-Boot, v3, " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170917132855.GG4560@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox