From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 3/8] treewide: replace with error() with pr_err()
Date: Thu, 28 Sep 2017 09:11:14 -0400 [thread overview]
Message-ID: <20170928131114.GL3112@bill-the-cat> (raw)
In-Reply-To: <CAK7LNASsd+PHJWdfyb11PdrwjQnT0kbFpznKWeDf426PpjAh6g@mail.gmail.com>
On Thu, Sep 28, 2017 at 09:56:29PM +0900, Masahiro Yamada wrote:
> Hi Tom,
>
>
> 2017-09-28 21:43 GMT+09:00 Tom Rini <trini@konsulko.com>:
> > On Thu, Sep 28, 2017 at 03:11:05PM +0900, Masahiro Yamada wrote:
> >> Hi Tom,
> >>
> >> 2017-09-16 14:10 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> >> > U-Boot widely uses error() as a bit noisier variant of printf().
> >> >
> >> > This macro causes name conflict with the following line in
> >> > include/linux/compiler-gcc.h:
> >> >
> >> > # define __compiletime_error(message) __attribute__((error(message)))
> >> >
> >> > This prevents us from using __compiletime_error(), and makes it
> >> > difficult to fully sync BUILD_BUG macros with Linux. (Notice
> >> > Linux's BUILD_BUG_ON_MSG is implemented by using compiletime_assert().)
> >> >
> >> > Let's convert error() into now treewide-available pr_err().
> >> >
> >> > Done with the help of Coccinelle, excluing tools/ directory.
> >> >
> >> > The semantic patch I used is as follows:
> >> >
> >> > // <smpl>
> >> > @@@@
> >> > -error
> >> > +pr_err
> >> > (...)
> >> > // </smpl>
> >>
> >>
> >> Apparently, this is outdated already.
> >>
> >> Do you want me to update this?
> >> or will you run coccinelle by yourself?
> >
> > Well, that was my first time running coccinelle, and it was rather
> > painless. So yes, I'm happy to re-generate any coccinelle generated
> > patches so long as the smpl is included in the commit message. Thanks!
> >
>
>
> OK, I will not resend this series.
> This one is quite big, and would go to the moderator.
>
>
> One more request, if you will remember, would you fix my typo in the subject?
>
> "replace with error() with pr_error()"
>
> I noticed the first "with" was unneeded.
OK, will do.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170928/6af4cf46/attachment.sig>
next prev parent reply other threads:[~2017-09-28 13:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-16 5:10 [U-Boot] [PATCH v2 0/8] Sync and consolidate Linux-derived printk, BUILD_BUG, BUG, WARN, etc Masahiro Yamada
2017-09-16 5:10 ` [U-Boot] [PATCH v2 1/8] stdio.h: move printf() stuff from <common.h> to <stdio.h> Masahiro Yamada
2017-10-05 21:51 ` [U-Boot] [U-Boot, v2, " Tom Rini
2017-09-16 5:10 ` [U-Boot] [PATCH v2 2/8] printk: collect printk stuff into <linux/printk.h> with loglevel support Masahiro Yamada
2017-10-05 21:52 ` [U-Boot] [U-Boot, v2, " Tom Rini
2017-09-16 5:10 ` [U-Boot] [PATCH v2 3/8] treewide: replace with error() with pr_err() Masahiro Yamada
2017-09-25 2:15 ` Simon Glass
2017-09-28 6:11 ` Masahiro Yamada
2017-09-28 12:43 ` Tom Rini
2017-09-28 12:56 ` Masahiro Yamada
2017-09-28 13:11 ` Tom Rini [this message]
2017-10-05 21:52 ` [U-Boot] [U-Boot, v2, " Tom Rini
2017-09-16 5:10 ` [U-Boot] [PATCH v2 4/8] common.h: remove error() Masahiro Yamada
2017-10-05 21:52 ` [U-Boot] [U-Boot,v2,4/8] " Tom Rini
2017-09-16 5:10 ` [U-Boot] [PATCH v2 5/8] vsprintf.h: include <linux/types.h> Masahiro Yamada
2017-10-05 21:52 ` [U-Boot] [U-Boot,v2,5/8] " Tom Rini
2017-09-16 5:10 ` [U-Boot] [PATCH v2 6/8] bug.h: sync BUILD_BUG stuff with Linux 4.13 Masahiro Yamada
2017-10-05 21:52 ` [U-Boot] [U-Boot, v2, " Tom Rini
2017-09-16 5:10 ` [U-Boot] [PATCH v2 7/8] bug.h: move runtime BUG/WARN macros into <linux/bug.h> Masahiro Yamada
2017-10-05 21:52 ` [U-Boot] [U-Boot, v2, " Tom Rini
2017-09-16 5:10 ` [U-Boot] [PATCH v2 8/8] dm: define dev_*() log functions in DM header Masahiro Yamada
2017-09-25 2:15 ` Simon Glass
2017-09-26 3:00 ` Masahiro Yamada
2017-10-04 5:15 ` [U-Boot] [PATCH v2 0/8] Sync and consolidate Linux-derived printk, BUILD_BUG, BUG, WARN, etc Masahiro Yamada
2017-10-05 3:06 ` Tom Rini
2017-10-05 3:20 ` Masahiro Yamada
2017-10-05 11:58 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170928131114.GL3112@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox