[U-Boot] [PATCH v3 02/21] part: extract MBR signature from partitions

Rob Clark
2017-10-02T19:35:46Z

On Mon, Oct 2, 2017 at 2:17 PM, Fabio Estevam <festevam@gmail.com> wrote:
> On Wed, Sep 13, 2017 at 7:05 PM, Rob Clark <robdclark@gmail.com> wrote:
>> From: Peter Jones <pjones@redhat.com>
>>
>> EFI client programs need the signature information from the partition
>> table to determine the disk a partition is on, so we need to fill that
>> in here.
>>
>> Signed-off-by: Peter Jones <pjones@redhat.com>
>> [separated from efi_loader part, and fixed build-errors for non-
>> CONFIG_EFI_PARTITION case]
>> Signed-off-by: Rob Clark <robdclark@gmail.com>
>
> This is commit ff98cb90514d9b78 in mainline now and breaks all mx6 SPL boots:
>
> U-Boot SPL 2017.09-00221-g0d6ab32 (Oct 02 2017 - 15:13:19)
> Trying to boot from MMC1
> (hangs here)
>
> Does anyone know how to fix this problem?

not sure to what extent debug()/printf() works from SPL, but if it
does maybe adding this patch with and without that commit and
comparing logs would give some hint:

--------------
diff --git a/disk/part.c b/disk/part.c
index aa9183d696..8e0bf54b3e 100644
--- a/disk/part.c
+++ b/disk/part.c
@@ -5,6 +5,8 @@
* SPDX-License-Identifier: GPL-2.0+
*/

+#define DEBUG
+
#include <common.h>
#include <command.h>
#include <errno.h>
@@ -13,7 +15,7 @@
#include <part.h>
#include <ubifs_uboot.h>

-#undef PART_DEBUG
+#define PART_DEBUG

#ifdef PART_DEBUG
#define PRINTF(fmt,args...) printf (fmt ,##args)
--------------

I don't really see why this commit would cause problems, but I guess
either something unexpected going on w/ partitions or block device
driver on this platform..

BR,
-R