From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 0/8] Sync and consolidate Linux-derived printk, BUILD_BUG, BUG, WARN, etc.
Date: Thu, 5 Oct 2017 07:58:03 -0400 [thread overview]
Message-ID: <20171005115803.GF13661@bill-the-cat> (raw)
In-Reply-To: <CAK7LNARHzK4uB1vioEi=tJdhgDZ+iiC1tbD3UB=vOrsXqWabVg@mail.gmail.com>
On Thu, Oct 05, 2017 at 12:20:36PM +0900, Masahiro Yamada wrote:
> Hi Tom,
>
>
> 2017-10-05 12:06 GMT+09:00 Tom Rini <trini@konsulko.com>:
> > On Wed, Oct 04, 2017 at 02:15:19PM +0900, Masahiro Yamada wrote:
> >> 2017-09-16 14:10 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> >> >
> >> > I tested this series with buildman.
> >> >
> >> >
> >> >
> >> > Masahiro Yamada (8):
> >> > stdio.h: move printf() stuff from <common.h> to <stdio.h>
> >> > printk: collect printk stuff into <linux/printk.h> with loglevel
> >> > support
> >> > treewide: replace with error() with pr_err()
> >> > common.h: remove error()
> >> > vsprintf.h: include <linux/types.h>
> >> > bug.h: sync BUILD_BUG stuff with Linux 4.13
> >> > bug.h: move runtime BUG/WARN macros into <linux/bug.h>
> >> > dm: define dev_*() log functions in DM header
> >>
> >> I am still worried if this series is dismissed.
> >>
> >> I am being blocked from importing NAND code from Linux
> >> due to missing/incompatible Linux-derived macros.
> >
> > I am looking at this, but a default LOGLEVEL of 5 is just too high and
> > I'm seeing what's reasonable now.
> >
>
> No. I set the default to 6, not 5.
>
> The reason why I chose 6 was to suppress a bunch of pr_info()
> from drivers/mtd/nand/, which is a copy of Linux.
>
>
> If you change it to a bigger number,
> some annoying logs would be displayed after NAND: tag.
>
> If you change it to a smaller number,
> pr_notice() would be suppressed.
>
>
> The Linux doc says:
>
> 5 (KERN_NOTICE) normal but significant condition
>
>
> So, I think this is worth printing by default.
>
>
> If you do not like it, you can change it,
> but please make sure to adjust git-log.
Yes, sorry. You set it to 6, I had already ruled out 5 as too much.
I'm currently looking at 3 globally as otherwise most platforms are
growing by 5KiB or more (often much more). And I'm going to do it as a
follow-up commit so it's clear.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171005/6b593ee5/attachment.sig>
prev parent reply other threads:[~2017-10-05 11:58 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-16 5:10 [U-Boot] [PATCH v2 0/8] Sync and consolidate Linux-derived printk, BUILD_BUG, BUG, WARN, etc Masahiro Yamada
2017-09-16 5:10 ` [U-Boot] [PATCH v2 1/8] stdio.h: move printf() stuff from <common.h> to <stdio.h> Masahiro Yamada
2017-10-05 21:51 ` [U-Boot] [U-Boot, v2, " Tom Rini
2017-09-16 5:10 ` [U-Boot] [PATCH v2 2/8] printk: collect printk stuff into <linux/printk.h> with loglevel support Masahiro Yamada
2017-10-05 21:52 ` [U-Boot] [U-Boot, v2, " Tom Rini
2017-09-16 5:10 ` [U-Boot] [PATCH v2 3/8] treewide: replace with error() with pr_err() Masahiro Yamada
2017-09-25 2:15 ` Simon Glass
2017-09-28 6:11 ` Masahiro Yamada
2017-09-28 12:43 ` Tom Rini
2017-09-28 12:56 ` Masahiro Yamada
2017-09-28 13:11 ` Tom Rini
2017-10-05 21:52 ` [U-Boot] [U-Boot, v2, " Tom Rini
2017-09-16 5:10 ` [U-Boot] [PATCH v2 4/8] common.h: remove error() Masahiro Yamada
2017-10-05 21:52 ` [U-Boot] [U-Boot,v2,4/8] " Tom Rini
2017-09-16 5:10 ` [U-Boot] [PATCH v2 5/8] vsprintf.h: include <linux/types.h> Masahiro Yamada
2017-10-05 21:52 ` [U-Boot] [U-Boot,v2,5/8] " Tom Rini
2017-09-16 5:10 ` [U-Boot] [PATCH v2 6/8] bug.h: sync BUILD_BUG stuff with Linux 4.13 Masahiro Yamada
2017-10-05 21:52 ` [U-Boot] [U-Boot, v2, " Tom Rini
2017-09-16 5:10 ` [U-Boot] [PATCH v2 7/8] bug.h: move runtime BUG/WARN macros into <linux/bug.h> Masahiro Yamada
2017-10-05 21:52 ` [U-Boot] [U-Boot, v2, " Tom Rini
2017-09-16 5:10 ` [U-Boot] [PATCH v2 8/8] dm: define dev_*() log functions in DM header Masahiro Yamada
2017-09-25 2:15 ` Simon Glass
2017-09-26 3:00 ` Masahiro Yamada
2017-10-04 5:15 ` [U-Boot] [PATCH v2 0/8] Sync and consolidate Linux-derived printk, BUILD_BUG, BUG, WARN, etc Masahiro Yamada
2017-10-05 3:06 ` Tom Rini
2017-10-05 3:20 ` Masahiro Yamada
2017-10-05 11:58 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171005115803.GF13661@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox