From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, v2, 2/8] printk: collect printk stuff into <linux/printk.h> with loglevel support
Date: Thu, 5 Oct 2017 17:52:04 -0400 [thread overview]
Message-ID: <20171005215204.GJ25966@bill-the-cat> (raw)
In-Reply-To: <1505538646-19191-3-git-send-email-yamada.masahiro@socionext.com>
On Sat, Sep 16, 2017 at 02:10:40PM +0900, Masahiro Yamada wrote:
> When we import code from Linux, with regular re-sync planned, we want
> to use printk() and pr_*(). U-Boot does not support them in a clean
> way. So, people end up with local macros, or compat headers here and
> there, then we occasionally see build errors of definition conflicts.
>
> We have include/linux/compat.h, but putting all sorts of unrelated
> things into a single header is just a temporal workaround. Hence this
> patch, to find the best home for all printk variants. If you want to
> use printk() and friends, please include <linux/printk.h>. This header
> is self-contained, and pulls in only a few headers.
>
> When I was testing this clean-up, I noticed the image size exceeded
> its platform limit on some boards. This is because all pr_*() that
> were previously defined as no-op in include/linux/mtd/mtd.h (unless
> CONFIG_MTD_DEBUG is set), are now enabled.
>
> To make such boards happy, this commit also implements CONFIG_LOGLEVEL.
> The concept is similar to the kernel parameter "loglevel". (Actually,
> the Kconfig help message was taken from kernel-paremeter.txt of Linux)
> Messages with a loglevel smaller than console loglevel will be printed.
>
> The difference is the loglevel is build-time determined. To save the
> image size, lower priority pr_*() are compiled out. I set the default
> of CONFIG_LOGLEVEL to 6, i.e. pr_notice and higher priority messages
> are compiled in.
>
> I adjusted CONFIG_LOGLEVEL to avoid build error for some boards.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171005/e971b9ac/attachment.sig>
next prev parent reply other threads:[~2017-10-05 21:52 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-16 5:10 [U-Boot] [PATCH v2 0/8] Sync and consolidate Linux-derived printk, BUILD_BUG, BUG, WARN, etc Masahiro Yamada
2017-09-16 5:10 ` [U-Boot] [PATCH v2 1/8] stdio.h: move printf() stuff from <common.h> to <stdio.h> Masahiro Yamada
2017-10-05 21:51 ` [U-Boot] [U-Boot, v2, " Tom Rini
2017-09-16 5:10 ` [U-Boot] [PATCH v2 2/8] printk: collect printk stuff into <linux/printk.h> with loglevel support Masahiro Yamada
2017-10-05 21:52 ` Tom Rini [this message]
2017-09-16 5:10 ` [U-Boot] [PATCH v2 3/8] treewide: replace with error() with pr_err() Masahiro Yamada
2017-09-25 2:15 ` Simon Glass
2017-09-28 6:11 ` Masahiro Yamada
2017-09-28 12:43 ` Tom Rini
2017-09-28 12:56 ` Masahiro Yamada
2017-09-28 13:11 ` Tom Rini
2017-10-05 21:52 ` [U-Boot] [U-Boot, v2, " Tom Rini
2017-09-16 5:10 ` [U-Boot] [PATCH v2 4/8] common.h: remove error() Masahiro Yamada
2017-10-05 21:52 ` [U-Boot] [U-Boot,v2,4/8] " Tom Rini
2017-09-16 5:10 ` [U-Boot] [PATCH v2 5/8] vsprintf.h: include <linux/types.h> Masahiro Yamada
2017-10-05 21:52 ` [U-Boot] [U-Boot,v2,5/8] " Tom Rini
2017-09-16 5:10 ` [U-Boot] [PATCH v2 6/8] bug.h: sync BUILD_BUG stuff with Linux 4.13 Masahiro Yamada
2017-10-05 21:52 ` [U-Boot] [U-Boot, v2, " Tom Rini
2017-09-16 5:10 ` [U-Boot] [PATCH v2 7/8] bug.h: move runtime BUG/WARN macros into <linux/bug.h> Masahiro Yamada
2017-10-05 21:52 ` [U-Boot] [U-Boot, v2, " Tom Rini
2017-09-16 5:10 ` [U-Boot] [PATCH v2 8/8] dm: define dev_*() log functions in DM header Masahiro Yamada
2017-09-25 2:15 ` Simon Glass
2017-09-26 3:00 ` Masahiro Yamada
2017-10-04 5:15 ` [U-Boot] [PATCH v2 0/8] Sync and consolidate Linux-derived printk, BUILD_BUG, BUG, WARN, etc Masahiro Yamada
2017-10-05 3:06 ` Tom Rini
2017-10-05 3:20 ` Masahiro Yamada
2017-10-05 11:58 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171005215204.GJ25966@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox