public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] imx: mx7dsabresd: include BLK for MMC/eMMC support of driver model
Date: Wed, 11 Oct 2017 16:51:13 -0400	[thread overview]
Message-ID: <20171011205113.GP12015@bill-the-cat> (raw)
In-Reply-To: <CAOMZO5BFU67s5B+ws7de4Z_waGbEfGuZys6iAs6a5dOB_hSoxA@mail.gmail.com>

On Wed, Oct 11, 2017 at 05:50:04PM -0300, Fabio Estevam wrote:
> Hi Eric,
> 
> That was the fix I was waiting for, thanks!
> 
> On Wed, Oct 11, 2017 at 5:29 PM, Eric Nelson <eric@nelint.com> wrote:
> 
> Please add a commit log and explain that this fixes a regression.
> 
> > Change-Id: I1bdfffe782a61a4c688f1bb56e85448024cd497b
> 
> Please remove this line.
> 
> Also, when you send a v2, please do the same change in
> mx7dsabresd_secure_defconfig.
> 
> > Signed-off-by: Eric Nelson <eric@nelint.com>
> 
> Now I can boot a kernel successfully, thanks:
> 
> Tested-by: Fabio Estevam <fabio.estevam@nxp.com>

Is there perhaps a dependency here we need to enforce via Kconfig so
this isn't a game of whack-a-mole?  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171011/468d3322/attachment.sig>

  reply	other threads:[~2017-10-11 20:51 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-11 14:23 [U-Boot] [PATCH] mx7dsabresd: Remove CONFIG_DM_MMC to avoid regression Fabio Estevam
2017-10-11 14:27 ` Otavio Salvador
2017-10-11 15:38   ` Fabio Estevam
2017-10-11 20:29     ` [U-Boot] [PATCH] imx: mx7dsabresd: include BLK for MMC/eMMC support of driver model Eric Nelson
2017-10-11 20:41       ` Jagan Teki
2017-10-11 20:50       ` Fabio Estevam
2017-10-11 20:51         ` Tom Rini [this message]
2017-10-11 21:40           ` Eric Nelson
2017-10-11 21:14         ` Eric Nelson
2017-10-11 21:45       ` [U-Boot] [PATCH V2] " Eric Nelson
2017-10-11 21:49         ` Tom Rini
2017-10-11 21:53           ` Fabio Estevam
2017-10-11 21:55             ` Tom Rini
2017-10-11 22:07               ` Fabio Estevam
2017-10-11 22:17                 ` Tom Rini
2017-10-11 22:28                   ` Fabio Estevam
2017-10-12 16:33                   ` Tom Rini
2017-10-12 18:35                     ` Fabio Estevam
2017-10-12 18:38                       ` Tom Rini
2017-10-12 18:39                         ` Fabio Estevam
2017-10-12 18:49                           ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171011205113.GP12015@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox