From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] efi_loader: Do not enable it by default for sunxi
Date: Thu, 19 Oct 2017 13:52:49 +0200 [thread overview]
Message-ID: <20171019115249.viayrnhfbaaz6ldm@flea> (raw)
In-Reply-To: <9d6825b2-2212-cd01-7fb5-9e962dc0d04d@suse.de>
On Thu, Oct 19, 2017 at 10:51:04AM +0200, Alexander Graf wrote:
> > lib/efi_loader/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
> > index d2b6327119b4..a80a914b2fe8 100644
> > --- a/lib/efi_loader/Kconfig
> > +++ b/lib/efi_loader/Kconfig
> > @@ -1,7 +1,7 @@
> > config EFI_LOADER
> > bool "Support running EFI Applications in U-Boot"
> > depends on (ARM || X86) && OF_LIBFDT
> > - default y
> > + default y if !ARCH_SUNXI
>
> Nack on any change to that default line. If you must disable efi_loader (and
> really, I strongly advise not to do so for sunxi), please do so in the
> defconfigs, as nothing prohibits the architecture to work with it.
That's a bit of a separate discussion. We don't want to have too much
churn in the defconfig, as it is basically boilerplate that some will
get wrong, and then you won't have a consistent tool set between
boards, which is also a pain. A pain both to maintain and use if you
want to ship something board agnostic.
However, the preferred way expressed by Tom to change defaults has
been to change those defaults directly in the Kconfig option, instead
of them creeping in everywhere in the arch's or platform Kconfig
files.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171019/c30e0911/attachment.sig>
next prev parent reply other threads:[~2017-10-19 11:52 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 8:26 [U-Boot] [PATCH 0/3] sunxi: Fix boot of Cubietruk and al Maxime Ripard
2017-10-19 8:26 ` [U-Boot] [PATCH 1/3] ARM: sunxi: Disable USB host options by default Maxime Ripard
2017-10-19 8:48 ` Alexander Graf
2017-10-19 9:11 ` Andre Przywara
2017-10-19 11:55 ` Maxime Ripard
2017-10-19 8:54 ` Peter Robinson
2017-10-19 11:44 ` Mark Kettenis
2017-10-19 8:26 ` [U-Boot] [PATCH 2/3] ARM: sunxi: Disable FAT write " Maxime Ripard
2017-10-19 8:26 ` [U-Boot] [PATCH 3/3] efi_loader: Do not enable it by default for sunxi Maxime Ripard
2017-10-19 8:43 ` Peter Robinson
2017-10-19 9:01 ` Maxime Ripard
2017-10-19 9:06 ` Peter Robinson
2017-10-19 9:12 ` Peter Robinson
2017-10-19 11:43 ` Maxime Ripard
2017-10-19 21:40 ` Rob Clark
2017-10-20 7:20 ` Maxime Ripard
2017-10-20 12:27 ` Peter Robinson
2017-10-20 12:36 ` Maxime Ripard
2017-10-20 12:54 ` Tom Rini
2017-10-20 16:39 ` Maxime Ripard
2017-10-20 17:57 ` Tom Rini
2017-10-20 18:52 ` Peter Robinson
2017-10-20 12:56 ` Peter Robinson
2017-10-19 9:12 ` Maxime Ripard
2017-10-23 13:35 ` Heinrich Schuchardt
2017-10-19 8:51 ` Alexander Graf
2017-10-19 10:54 ` Jonathan Gray
2017-10-19 11:52 ` Maxime Ripard [this message]
2017-10-19 11:39 ` Mark Kettenis
2017-10-19 11:48 ` Maxime Ripard
2017-10-19 13:24 ` Tom Rini
2017-10-19 8:44 ` [U-Boot] [PATCH 0/3] sunxi: Fix boot of Cubietruk and al Alexander Graf
2017-10-19 9:11 ` Maxime Ripard
2017-10-19 12:10 ` Alexander Graf
2017-10-19 9:10 ` Siarhei Siamashka
2017-10-19 13:20 ` Tom Rini
2017-10-19 13:26 ` Maxime Ripard
2017-10-19 13:03 ` Andre Przywara
2017-10-19 13:24 ` Maxime Ripard
2017-10-19 13:31 ` Tom Rini
2017-10-19 14:42 ` Andre Przywara
2017-10-19 14:58 ` Maxime Ripard
2017-10-20 21:33 ` Dennis Gilmore
2017-10-23 7:35 ` Maxime Ripard
2017-10-24 17:05 ` Dennis Gilmore
2017-10-24 17:21 ` Andre Przywara
2017-10-25 9:42 ` Maxime Ripard
2017-10-25 9:55 ` Jagan Teki
2017-10-25 12:30 ` Maxime Ripard
2017-10-25 10:01 ` Andre Przywara
2017-10-25 11:58 ` Siarhei Siamashka
2017-10-25 13:42 ` Andre Przywara
[not found] ` <20171025184101.aihe47qongf52e7c@excalibur.cnev.de>
2017-10-26 1:46 ` Dennis Gilmore
2017-10-25 13:45 ` Tom Rini
2017-10-25 13:50 ` Maxime Ripard
2017-10-20 21:31 ` Dennis Gilmore
2017-10-19 13:28 ` Tom Rini
2017-10-19 13:50 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171019115249.viayrnhfbaaz6ldm@flea \
--to=maxime.ripard@free-electrons.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox