public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, v3, 3/6] disk: efi: correct the overlap check on GPT header and PTE
Date: Tue, 24 Oct 2017 14:15:25 -0400	[thread overview]
Message-ID: <20171024181525.GM22919@bill-the-cat> (raw)
In-Reply-To: <1508332268-2280-4-git-send-email-patrick.delaunay@st.com>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="windows-1254", Size: 1416 bytes --]

On Wed, Oct 18, 2017 at 03:11:05PM +0200, Patrick Delaunay wrote:

> the partition starting at 0x4400 is refused with overlap error:
>   $> gpt write mmc 0 "name=test,start=0x4400,size=0"
>   Writing GPT: Partition overlap
>   error!
> 
> even if the 0x4400 is the first available offset for LBA35 with default
> value:
> - MBR=LBA1
> - GPT header=LBA2
> - PTE= 32 LBAs (128 entry), 3 to 34
> 
> And the command to have one partition for all the disk failed also :
>   $> gpt write mmc 0 "name=test,size=0"
> 
> After the patch :
> 
>   $> gpt write mmc 0 "name=test,size=0"
>   Writing GPT: success!
>   $> part list mmc 0
> 
>   Partition Map for MMC device 0  --   Partition Type: EFI
> 
>   Part	Start LBA	End LBA		Name
> 	Attributes
> 	Type GUID
> 	Partition GUID
>   1	0x00000022	0x01ce9fde	"test"
> 	attrs:	0x0000000000000000
> 	type:	ebd0a0a2-b9e5-4433-87c0-68b6b72699c7
> 	type:	data
> 	guid:	b4b84b8a-04e3-4000-0036-aff5c9c495b1
> 
> And 0x22 = 34 LBA => offset = 0x4400 is accepted as expected
> 
> Reviewed-by: Łukasz Majewski <lukma@denx.de>
> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171024/0a992428/attachment.sig>

  reply	other threads:[~2017-10-24 18:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-18 13:11 [U-Boot] [PATCH v3 0/6] solve issues in gpt management Patrick Delaunay
2017-10-18 13:11 ` [U-Boot] [PATCH v3 1/6] test/py: gpt: copy persistent file Patrick Delaunay
2017-10-24 18:15   ` [U-Boot] [U-Boot,v3,1/6] " Tom Rini
2017-10-18 13:11 ` [U-Boot] [PATCH v3 2/6] test/py: gpt: add test for sub-command read and verify Patrick Delaunay
2017-10-24 18:15   ` [U-Boot] [U-Boot, v3, " Tom Rini
2017-10-18 13:11 ` [U-Boot] [PATCH v3 3/6] disk: efi: correct the overlap check on GPT header and PTE Patrick Delaunay
2017-10-24 18:15   ` Tom Rini [this message]
2017-10-18 13:11 ` [U-Boot] [PATCH v3 4/6] test/py: gpt: add test for sub-command write Patrick Delaunay
2017-10-24 18:15   ` [U-Boot] [U-Boot, v3, " Tom Rini
2017-10-18 13:11 ` [U-Boot] [PATCH v3 5/6] test/py: gpt: test start LBA for sub-command rename and swap Patrick Delaunay
2017-10-24 18:15   ` [U-Boot] [U-Boot, v3, " Tom Rini
2017-10-18 13:11 ` [U-Boot] [PATCH v3 6/6] cmd: gpt: solve issue for swap and rename command Patrick Delaunay
2017-10-18 17:13   ` Stephen Warren
2017-10-19 13:15     ` Patrick DELAUNAY
2017-10-24 18:15   ` [U-Boot] [U-Boot, v3, " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171024181525.GM22919@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox