* [U-Boot] Where should Renesas RZ/A go under arch/arm/ ???? @ 2017-10-31 12:13 Chris Brandt 2017-10-31 15:14 ` Tom Rini 0 siblings, 1 reply; 6+ messages in thread From: Chris Brandt @ 2017-10-31 12:13 UTC (permalink / raw) To: u-boot Hello, Since I've been supporting a u-boot for the Renesas RZ/A1 SoC for a while now, I thought I'd start upstreaming the drivers/patches I've acquired over the years. But, where should the core files and Kconfig go? The RZ/A1 series has a Cortex-A9. At first, I had made a directory under arch/arm/cpu/armv7/ But, now I see things are moving under arch/arm/mach-xxxx. There is a arch/arm/mach-rmobile directory that has the Renesas R-Car devices. But while the RZ/A1 uses some of the same HW IP blocks, for the most part it's a different product line. So, Where should I put my RZ/A1 (and future RZ/A devices, or future RZ/N devices)? 1. Keep all Renesas parts together like we do in the kernel (arm/mach-shmobile)? u-boot/arch/arm/mach-rmobile 2. Create a new directory just for the RZ/A series? u-boot/arch/arm/mach-rza 3. Create a new directory just for any Renesas parts that are not rmobile? u-boot/arch/arm/mach-renesas The one issue with #2 and #3 is that currently arch/arm/Kconfig has config ARCH_RMOBILE bool "Renesas ARM SoCs" Which basically tells users that any Renesas SoC would be under mach-rmobile. So, if I at least know what directory I should start with, I can figure out how to make the rest work. Thank you, Chris ^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] Where should Renesas RZ/A go under arch/arm/ ???? 2017-10-31 12:13 [U-Boot] Where should Renesas RZ/A go under arch/arm/ ???? Chris Brandt @ 2017-10-31 15:14 ` Tom Rini 2017-10-31 15:26 ` Chris Brandt 0 siblings, 1 reply; 6+ messages in thread From: Tom Rini @ 2017-10-31 15:14 UTC (permalink / raw) To: u-boot On Tue, Oct 31, 2017 at 12:13:22PM +0000, Chris Brandt wrote: > Hello, > > Since I've been supporting a u-boot for the Renesas RZ/A1 SoC for a > while now, I thought I'd start upstreaming the drivers/patches I've acquired > over the years. > > But, where should the core files and Kconfig go? > > The RZ/A1 series has a Cortex-A9. > > At first, I had made a directory under arch/arm/cpu/armv7/ > > But, now I see things are moving under arch/arm/mach-xxxx. > > There is a arch/arm/mach-rmobile directory that has the Renesas R-Car > devices. But while the RZ/A1 uses some of the same HW IP blocks, for the > most part it's a different product line. > > So, Where should I put my RZ/A1 (and future RZ/A devices, or future RZ/N > devices)? > > 1. Keep all Renesas parts together like we do in the kernel (arm/mach-shmobile)? > > u-boot/arch/arm/mach-rmobile I would vote for renaming and matching the kernel here and using mach-shmobile. Thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171031/e439d1d6/attachment.sig> ^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] Where should Renesas RZ/A go under arch/arm/ ???? 2017-10-31 15:14 ` Tom Rini @ 2017-10-31 15:26 ` Chris Brandt 2017-11-01 2:09 ` Tom Rini 0 siblings, 1 reply; 6+ messages in thread From: Chris Brandt @ 2017-10-31 15:26 UTC (permalink / raw) To: u-boot Hi Tom, Thanks for the reply! On Tuesday, October 31, 2017 1, Tom Rini wrote: > On Tue, Oct 31, 2017 at 12:13:22PM +0000, Chris Brandt wrote: > > Hello, > > > > Since I've been supporting a u-boot for the Renesas RZ/A1 SoC for a > > while now, I thought I'd start upstreaming the drivers/patches I've > acquired > > over the years. > > > > But, where should the core files and Kconfig go? > > > > The RZ/A1 series has a Cortex-A9. > > > > At first, I had made a directory under arch/arm/cpu/armv7/ > > > > But, now I see things are moving under arch/arm/mach-xxxx. > > > > There is a arch/arm/mach-rmobile directory that has the Renesas R-Car > > devices. But while the RZ/A1 uses some of the same HW IP blocks, for the > > most part it's a different product line. > > > > So, Where should I put my RZ/A1 (and future RZ/A devices, or future RZ/N > > devices)? > > > > 1. Keep all Renesas parts together like we do in the kernel (arm/mach- > shmobile)? > > > > u-boot/arch/arm/mach-rmobile > > I would vote for renaming and matching the kernel here and using > mach-shmobile. Thanks! Ugh! That shmobile name is going to haunt us forever (even though we don't even make SH-Mobile parts anymore....and they are all ARM cores now, not SH). I will say that upstream in the kernel, most everything else has been renamed to "renesas" (ie, ARCH_RENESAS, )...except that directory name. I asked if/when they would rename it, but at the moment, there is not plan as not to break anything. Maybe we can compromise on everything in mach-renesas?? Chris ^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] Where should Renesas RZ/A go under arch/arm/ ???? 2017-10-31 15:26 ` Chris Brandt @ 2017-11-01 2:09 ` Tom Rini 2017-11-13 1:02 ` Nobuhiro Iwamatsu 0 siblings, 1 reply; 6+ messages in thread From: Tom Rini @ 2017-11-01 2:09 UTC (permalink / raw) To: u-boot On Tue, Oct 31, 2017 at 03:26:02PM +0000, Chris Brandt wrote: > Hi Tom, > > Thanks for the reply! > > On Tuesday, October 31, 2017 1, Tom Rini wrote: > > On Tue, Oct 31, 2017 at 12:13:22PM +0000, Chris Brandt wrote: > > > Hello, > > > > > > Since I've been supporting a u-boot for the Renesas RZ/A1 SoC for a > > > while now, I thought I'd start upstreaming the drivers/patches I've > > acquired > > > over the years. > > > > > > But, where should the core files and Kconfig go? > > > > > > The RZ/A1 series has a Cortex-A9. > > > > > > At first, I had made a directory under arch/arm/cpu/armv7/ > > > > > > But, now I see things are moving under arch/arm/mach-xxxx. > > > > > > There is a arch/arm/mach-rmobile directory that has the Renesas R-Car > > > devices. But while the RZ/A1 uses some of the same HW IP blocks, for the > > > most part it's a different product line. > > > > > > So, Where should I put my RZ/A1 (and future RZ/A devices, or future RZ/N > > > devices)? > > > > > > 1. Keep all Renesas parts together like we do in the kernel (arm/mach- > > shmobile)? > > > > > > u-boot/arch/arm/mach-rmobile > > > > I would vote for renaming and matching the kernel here and using > > mach-shmobile. Thanks! > > > Ugh! That shmobile name is going to haunt us forever (even though we > don't even make SH-Mobile parts anymore....and they are all ARM cores now, > not SH). > > I will say that upstream in the kernel, most everything else has been > renamed to "renesas" (ie, ARCH_RENESAS, )...except that directory name. I > asked if/when they would rename it, but at the moment, there is not plan > as not to break anything. > > Maybe we can compromise on everything in mach-renesas?? OK, I can go with mach-renesas, thanks again! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171031/9bdecc4f/attachment.sig> ^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] Where should Renesas RZ/A go under arch/arm/ ???? 2017-11-01 2:09 ` Tom Rini @ 2017-11-13 1:02 ` Nobuhiro Iwamatsu 2017-11-13 15:07 ` Chris Brandt 0 siblings, 1 reply; 6+ messages in thread From: Nobuhiro Iwamatsu @ 2017-11-13 1:02 UTC (permalink / raw) To: u-boot Hi, I am sorry that my comment was delayed. 2017-11-01 11:09 GMT+09:00 Tom Rini <trini@konsulko.com>: > On Tue, Oct 31, 2017 at 03:26:02PM +0000, Chris Brandt wrote: >> Hi Tom, >> >> Thanks for the reply! >> >> On Tuesday, October 31, 2017 1, Tom Rini wrote: >> > On Tue, Oct 31, 2017 at 12:13:22PM +0000, Chris Brandt wrote: >> > > Hello, >> > > >> > > Since I've been supporting a u-boot for the Renesas RZ/A1 SoC for a >> > > while now, I thought I'd start upstreaming the drivers/patches I've >> > acquired >> > > over the years. >> > > >> > > But, where should the core files and Kconfig go? >> > > >> > > The RZ/A1 series has a Cortex-A9. >> > > >> > > At first, I had made a directory under arch/arm/cpu/armv7/ >> > > >> > > But, now I see things are moving under arch/arm/mach-xxxx. >> > > >> > > There is a arch/arm/mach-rmobile directory that has the Renesas R-Car >> > > devices. But while the RZ/A1 uses some of the same HW IP blocks, for the >> > > most part it's a different product line. >> > > >> > > So, Where should I put my RZ/A1 (and future RZ/A devices, or future RZ/N >> > > devices)? >> > > >> > > 1. Keep all Renesas parts together like we do in the kernel (arm/mach- >> > shmobile)? >> > > >> > > u-boot/arch/arm/mach-rmobile >> > >> > I would vote for renaming and matching the kernel here and using >> > mach-shmobile. Thanks! >> >> >> Ugh! That shmobile name is going to haunt us forever (even though we >> don't even make SH-Mobile parts anymore....and they are all ARM cores now, >> not SH). >> >> I will say that upstream in the kernel, most everything else has been >> renamed to "renesas" (ie, ARCH_RENESAS, )...except that directory name. I >> asked if/when they would rename it, but at the moment, there is not plan >> as not to break anything. >> >> Maybe we can compromise on everything in mach-renesas?? > > OK, I can go with mach-renesas, thanks again! +1 Chirs,: The reason we are using mach-rmobile is that the code merged first was rmobile SoC. As you say, these names are almost gone, and in the Linux kernel it is already mach-renesas. I am planning to move mach-rmobile to mach-renesas. How is your work situation? Best regards, Nopbuhiro -- Nobuhiro Iwamatsu iwamatsu at {nigauri.org / debian.org} GPG ID: 40AD1FA6 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] Where should Renesas RZ/A go under arch/arm/ ???? 2017-11-13 1:02 ` Nobuhiro Iwamatsu @ 2017-11-13 15:07 ` Chris Brandt 0 siblings, 0 replies; 6+ messages in thread From: Chris Brandt @ 2017-11-13 15:07 UTC (permalink / raw) To: u-boot Hello Nobuhiro On Sunday, November 12, 2017, Nobuhiro Iwamatsu wrote: > >> Maybe we can compromise on everything in mach-renesas?? > > > > OK, I can go with mach-renesas, thanks again! > > +1 > > Chirs,: > The reason we are using mach-rmobile is that the code merged first was > rmobile SoC. > As you say, these names are almost gone, and in the Linux kernel it is > already mach-renesas. > > I am planning to move mach-rmobile to mach-renesas. Great! I would be happy if you rename it, then I will add RZ/A (and maybe RZ/N). In the current RZ/A1 Renesas BSP, I added a new file Kconfig.rza: https://github.com/renesas-rz/rza_u-boot-2017.05/tree/master/arch/arm/mach-rmobile But for upstream, maybe I will add RZ/A to Kconfig.32 > How is your work situation? At first, I will just submit RZ/A driver patches: - Ethernet, SDHI, USB, timer, etc... Then, I will add RZ/A1 to Kconfig. So, if you will rename mach-rmobile -> mach-renesas in the future, I will just submit RZ/A1 driver patches for now. Chris ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-11-13 15:07 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-10-31 12:13 [U-Boot] Where should Renesas RZ/A go under arch/arm/ ???? Chris Brandt 2017-10-31 15:14 ` Tom Rini 2017-10-31 15:26 ` Chris Brandt 2017-11-01 2:09 ` Tom Rini 2017-11-13 1:02 ` Nobuhiro Iwamatsu 2017-11-13 15:07 ` Chris Brandt
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox