From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] gpt: Use cache aligned buffers for gpt_h and gpt_e
Date: Sun, 5 Nov 2017 23:18:12 +0100 [thread overview]
Message-ID: <20171105231812.1fdb3d69@jawa> (raw)
In-Reply-To: <1509100090-21903-1-git-send-email-lukma@denx.de>
On Fri, 27 Oct 2017 12:28:10 +0200
Lukasz Majewski <lukma@denx.de> wrote:
> Before this patch one could receive following errors when executing
> "gpt write" command on machine with cache enabled:
>
> display5 factory > gpt write mmc ${mmcdev} ${partitions}
> Writing GPT:
> CACHE: Misaligned operation at range [4ef8f7f0, 4ef8f9f0]
> CACHE: Misaligned operation at range [4ef8f9f8, 4ef939f8]
> CACHE: Misaligned operation at range [4ef8f9f8, 4ef939f8]
> CACHE: Misaligned operation at range [4ef8f7f0, 4ef8f9f0]
> success!
>
> To alleviate this problem - the calloc()s have been replaced with
> malloc_cache_aligned() and memset().
>
> After those changes the buffers are properly aligned (with both start
> address and size) to SoC cache line.
Any feedback?
This patch seems like a good candidate for v2017.11 (as a fix to gpt
command)
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171105/97fe067c/attachment.sig>
next prev parent reply other threads:[~2017-11-05 22:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-27 10:28 [U-Boot] [PATCH] gpt: Use cache aligned buffers for gpt_h and gpt_e Lukasz Majewski
2017-11-05 22:18 ` Lukasz Majewski [this message]
2017-11-06 23:28 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171105231812.1fdb3d69@jawa \
--to=lukma@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox