public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] board: imx6: marsboard: Remove doubled #include <asm/arch/sys_proto.h>
Date: Thu, 9 Nov 2017 10:49:59 +0100	[thread overview]
Message-ID: <20171109104959.0e41fc3a@jawa> (raw)
In-Reply-To: <e6a9fdfb-324d-882d-d91e-b913668d8f34@denx.de>

Hi Stefano,

> Hi Lukasz,
> 
> On 07/11/2017 11:10, Lukasz Majewski wrote:
> > The sys_proto.h file has been included earlier in this file.
> > 
> > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> > 
> > ---
> > 
> >  board/embest/mx6boards/mx6boards.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/board/embest/mx6boards/mx6boards.c
> > b/board/embest/mx6boards/mx6boards.c index ae04f68445..965e4f1ec8
> > 100644 --- a/board/embest/mx6boards/mx6boards.c
> > +++ b/board/embest/mx6boards/mx6boards.c
> > @@ -36,7 +36,7 @@
> >  #include <linux/fb.h>
> >  #include <ipu_pixfmt.h>
> >  #include <asm/io.h>
> > -#include <asm/arch/sys_proto.h>
> > +
> >  DECLARE_GLOBAL_DATA_PTR;
> >  
> >  #define UART_PAD_CTRL  (PAD_CTL_PUS_100K_UP
> > |			\ 
> 
> Thanks for fix - applied to u-boot-imx, -master !

You are welcome :-)

I've also sent a commit, which adds #ifdef guards to sys_proto.h.

> 
> I have reapplied support for display5, and I am testing the build
> again. If it is ok, I'll send as my last PR to Tom for 2017.11.

Great, thanks :)

> 
> Best regards,
> Stefano
> 



Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171109/1040632c/attachment.sig>

  reply	other threads:[~2017-11-09  9:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-31 12:26 [U-Boot] [PATCH] imx6: iomux: Add generic function to set RGMII IO voltage on IMX6 SoCs Lukasz Majewski
2017-11-07  9:23 ` Stefano Babic
2017-11-07  9:28   ` Stefano Babic
2017-11-07 10:12     ` Lukasz Majewski
2017-11-07 10:10   ` [U-Boot] [PATCH] board: imx6: marsboard: Remove doubled #include <asm/arch/sys_proto.h> Lukasz Majewski
2017-11-09  9:19     ` Stefano Babic
2017-11-09  9:49       ` Lukasz Majewski [this message]
2017-11-09 10:07         ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171109104959.0e41fc3a@jawa \
    --to=lukma@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox