From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Fri, 10 Nov 2017 13:09:32 +0100 Subject: [U-Boot] [PATCH] cmd: sf: remove useless pointer assignment In-Reply-To: <46edc78f8fbd21ab1a4f2313d634f4dd1b5bf2bd.1510228199.git.baruch@tkos.co.il> References: <46edc78f8fbd21ab1a4f2313d634f4dd1b5bf2bd.1510228199.git.baruch@tkos.co.il> Message-ID: <20171110130932.33d74442@jawa> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, 9 Nov 2017 13:49:59 +0200 Baruch Siach wrote: > The 'flash' pointer is assigned unconditionally a few lines below, > and is not used before that. > > Signed-off-by: Baruch Siach > --- > cmd/sf.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/cmd/sf.c b/cmd/sf.c > index f971eec781cc..9be8a89bc84c 100644 > --- a/cmd/sf.c > +++ b/cmd/sf.c > @@ -126,7 +126,6 @@ static int do_spi_flash_probe(int argc, char * > const argv[]) if (!ret) { > device_remove(new, DM_REMOVE_NORMAL); > } > - flash = NULL; > ret = spi_flash_probe_bus_cs(bus, cs, speed, mode, &new); > if (ret) { > printf("Failed to initialize SPI flash at %u:%u > (error %d)\n", Reviewed-by: Lukasz Majewski Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: