public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] Move Cache-As-RAM memory from area mapped to ROM in QEMU
@ 2017-11-10 17:51 Anton Gerasimov
  2017-11-10 22:49 ` Tom Rini
  2017-11-11 11:08 ` [U-Boot] " Heinrich Schuchardt
  0 siblings, 2 replies; 8+ messages in thread
From: Anton Gerasimov @ 2017-11-10 17:51 UTC (permalink / raw)
  To: u-boot

ROM has been made read-only in qemu recently (namely commit
208fa0e43645edd0b0d8f838857dfc79daff40a8), so this patch restores
compatibility between u-boot and qemu. It is still broken for me
unless I set CONFIG_SMP=n and disable lapic (i.e. revert patch
aaaa55751ab1e5a5cfa0962d604593a7e6f33ff6 in u-boot), but these are
separate issues

Signed-off-by: Anton Gerasimov <anton@advancedtelematic.com>
---
 arch/x86/cpu/qemu/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/cpu/qemu/Kconfig b/arch/x86/cpu/qemu/Kconfig
index 6808c9a6b9..f4b9922a34 100644
--- a/arch/x86/cpu/qemu/Kconfig
+++ b/arch/x86/cpu/qemu/Kconfig
@@ -11,7 +11,7 @@ if QEMU
 
 config SYS_CAR_ADDR
 	hex
-	default 0xd0000
+	default 0x10000
 
 config SYS_CAR_SIZE
 	hex
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [U-Boot] [PATCH] Move Cache-As-RAM memory from area mapped to ROM in QEMU
  2017-11-10 17:51 [U-Boot] [PATCH] Move Cache-As-RAM memory from area mapped to ROM in QEMU Anton Gerasimov
@ 2017-11-10 22:49 ` Tom Rini
  2017-11-11 11:08 ` [U-Boot] " Heinrich Schuchardt
  1 sibling, 0 replies; 8+ messages in thread
From: Tom Rini @ 2017-11-10 22:49 UTC (permalink / raw)
  To: u-boot

On Fri, Nov 10, 2017 at 06:51:02PM +0100, Anton Gerasimov wrote:

> ROM has been made read-only in qemu recently (namely commit
> 208fa0e43645edd0b0d8f838857dfc79daff40a8), so this patch restores
> compatibility between u-boot and qemu. It is still broken for me
> unless I set CONFIG_SMP=n and disable lapic (i.e. revert patch
> aaaa55751ab1e5a5cfa0962d604593a7e6f33ff6 in u-boot), but these are
> separate issues
> 
> Signed-off-by: Anton Gerasimov <anton@advancedtelematic.com>
> ---
>  arch/x86/cpu/qemu/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/cpu/qemu/Kconfig b/arch/x86/cpu/qemu/Kconfig
> index 6808c9a6b9..f4b9922a34 100644
> --- a/arch/x86/cpu/qemu/Kconfig
> +++ b/arch/x86/cpu/qemu/Kconfig
> @@ -11,7 +11,7 @@ if QEMU
>  
>  config SYS_CAR_ADDR
>  	hex
> -	default 0xd0000
> +	default 0x10000
>  
>  config SYS_CAR_SIZE
>  	hex

Bin, are you happy with this?  Do you want this in before release?
Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171110/678c2706/attachment.sig>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [U-Boot] Move Cache-As-RAM memory from area mapped to ROM in QEMU
  2017-11-10 17:51 [U-Boot] [PATCH] Move Cache-As-RAM memory from area mapped to ROM in QEMU Anton Gerasimov
  2017-11-10 22:49 ` Tom Rini
@ 2017-11-11 11:08 ` Heinrich Schuchardt
  2017-11-13 10:23   ` Anton Gerasimov
  1 sibling, 1 reply; 8+ messages in thread
From: Heinrich Schuchardt @ 2017-11-11 11:08 UTC (permalink / raw)
  To: u-boot

On 11/10/2017 06:51 PM, Anton Gerasimov wrote:
> ROM has been made read-only in qemu recently (namely commit
> 208fa0e43645edd0b0d8f838857dfc79daff40a8), so this patch restores
> compatibility between u-boot and qemu. It is still broken for me
> unless I set CONFIG_SMP=n and disable lapic (i.e. revert patch
> aaaa55751ab1e5a5cfa0962d604593a7e6f33ff6 in u-boot), but these are
> separate issues

I could not reproduce that reverting aaaa55751ab1 is necessary.
Your patch and CONFIG_SMP=n was suffcient to start U-Boot with
qemu-system-x86_64 version 2.10.1(Debian 1:2.10.0+dfsg-2)

Tested-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

> 
> Signed-off-by: Anton Gerasimov <anton@advancedtelematic.com>
> ---
>   arch/x86/cpu/qemu/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/cpu/qemu/Kconfig b/arch/x86/cpu/qemu/Kconfig
> index 6808c9a6b9..f4b9922a34 100644
> --- a/arch/x86/cpu/qemu/Kconfig
> +++ b/arch/x86/cpu/qemu/Kconfig
> @@ -11,7 +11,7 @@ if QEMU
>   
>   config SYS_CAR_ADDR
>   	hex
> -	default 0xd0000
> +	default 0x10000
>   
>   config SYS_CAR_SIZE
>   	hex
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [U-Boot] Move Cache-As-RAM memory from area mapped to ROM in QEMU
  2017-11-11 11:08 ` [U-Boot] " Heinrich Schuchardt
@ 2017-11-13 10:23   ` Anton Gerasimov
  2017-11-14 17:32     ` Heinrich Schuchardt
  0 siblings, 1 reply; 8+ messages in thread
From: Anton Gerasimov @ 2017-11-13 10:23 UTC (permalink / raw)
  To: u-boot

Thank you Heinrich, I can confirm that current u-boot master works
without reverting aaaa55751ab1. I had problems with u-boot v2017.11-rc2
apparently.

Best regards,
Anton Gerasimov

On 11/11/2017 12:08 PM, Heinrich Schuchardt wrote:
> On 11/10/2017 06:51 PM, Anton Gerasimov wrote:
>> ROM has been made read-only in qemu recently (namely commit
>> 208fa0e43645edd0b0d8f838857dfc79daff40a8), so this patch restores
>> compatibility between u-boot and qemu. It is still broken for me
>> unless I set CONFIG_SMP=n and disable lapic (i.e. revert patch
>> aaaa55751ab1e5a5cfa0962d604593a7e6f33ff6 in u-boot), but these are
>> separate issues
>
> I could not reproduce that reverting aaaa55751ab1 is necessary.
> Your patch and CONFIG_SMP=n was suffcient to start U-Boot with
> qemu-system-x86_64 version 2.10.1(Debian 1:2.10.0+dfsg-2)
>
> Tested-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>
>>
>> Signed-off-by: Anton Gerasimov <anton@advancedtelematic.com>
>> ---
>>   arch/x86/cpu/qemu/Kconfig | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/cpu/qemu/Kconfig b/arch/x86/cpu/qemu/Kconfig
>> index 6808c9a6b9..f4b9922a34 100644
>> --- a/arch/x86/cpu/qemu/Kconfig
>> +++ b/arch/x86/cpu/qemu/Kconfig
>> @@ -11,7 +11,7 @@ if QEMU
>>     config SYS_CAR_ADDR
>>       hex
>> -    default 0xd0000
>> +    default 0x10000
>>     config SYS_CAR_SIZE
>>       hex
>>
>

-- 
Anton Gerasimov, ATS Advanced Telematic Systems GmbH
Kantstrasse 162, 10623 Berlin
Managing Directors: Dirk Pöschl, Armin G. Schmidt
Register Court: HRB 151501 B, Amtsgericht Charlottenburg

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [U-Boot] Move Cache-As-RAM memory from area mapped to ROM in QEMU
  2017-11-13 10:23   ` Anton Gerasimov
@ 2017-11-14 17:32     ` Heinrich Schuchardt
  0 siblings, 0 replies; 8+ messages in thread
From: Heinrich Schuchardt @ 2017-11-14 17:32 UTC (permalink / raw)
  To: u-boot

On 11/13/2017 11:23 AM, Anton Gerasimov wrote:
> Thank you Heinrich, I can confirm that current u-boot master works
> without reverting aaaa55751ab1. I had problems with u-boot v2017.11-rc2
> apparently.

Could you, please, resubmit the patch with an updated commit message.

Regards

Heinrich
> 
> Best regards,
> Anton Gerasimov
> 
> On 11/11/2017 12:08 PM, Heinrich Schuchardt wrote:
>> On 11/10/2017 06:51 PM, Anton Gerasimov wrote:
>>> ROM has been made read-only in qemu recently (namely commit
>>> 208fa0e43645edd0b0d8f838857dfc79daff40a8), so this patch restores
>>> compatibility between u-boot and qemu. It is still broken for me
>>> unless I set CONFIG_SMP=n and disable lapic (i.e. revert patch
>>> aaaa55751ab1e5a5cfa0962d604593a7e6f33ff6 in u-boot), but these are
>>> separate issues
>>
>> I could not reproduce that reverting aaaa55751ab1 is necessary.
>> Your patch and CONFIG_SMP=n was suffcient to start U-Boot with
>> qemu-system-x86_64 version 2.10.1(Debian 1:2.10.0+dfsg-2)
>>
>> Tested-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>>
>>>
>>> Signed-off-by: Anton Gerasimov <anton@advancedtelematic.com>
>>> ---
>>>    arch/x86/cpu/qemu/Kconfig | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/x86/cpu/qemu/Kconfig b/arch/x86/cpu/qemu/Kconfig
>>> index 6808c9a6b9..f4b9922a34 100644
>>> --- a/arch/x86/cpu/qemu/Kconfig
>>> +++ b/arch/x86/cpu/qemu/Kconfig
>>> @@ -11,7 +11,7 @@ if QEMU
>>>      config SYS_CAR_ADDR
>>>        hex
>>> -    default 0xd0000
>>> +    default 0x10000
>>>      config SYS_CAR_SIZE
>>>        hex
>>>
>>
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [U-Boot] [PATCH] Move Cache-As-RAM memory from area mapped to ROM in QEMU
@ 2017-11-14 17:47 Anton Gerasimov
  2017-11-20  7:07 ` Bin Meng
  0 siblings, 1 reply; 8+ messages in thread
From: Anton Gerasimov @ 2017-11-14 17:47 UTC (permalink / raw)
  To: u-boot

ROM has been made read-only in qemu recently (namely commit
208fa0e43645edd0b0d8f838857dfc79daff40a8), so this patch restores
compatibility between u-boot and qemu.

Signed-off-by: Anton Gerasimov <anton@advancedtelematic.com>
---
 arch/x86/cpu/qemu/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/cpu/qemu/Kconfig b/arch/x86/cpu/qemu/Kconfig
index 6808c9a6b9..f4b9922a34 100644
--- a/arch/x86/cpu/qemu/Kconfig
+++ b/arch/x86/cpu/qemu/Kconfig
@@ -11,7 +11,7 @@ if QEMU
 
 config SYS_CAR_ADDR
 	hex
-	default 0xd0000
+	default 0x10000
 
 config SYS_CAR_SIZE
 	hex
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [U-Boot] [PATCH] Move Cache-As-RAM memory from area mapped to ROM in QEMU
  2017-11-14 17:47 [U-Boot] [PATCH] " Anton Gerasimov
@ 2017-11-20  7:07 ` Bin Meng
  2017-11-20  9:15   ` Bin Meng
  0 siblings, 1 reply; 8+ messages in thread
From: Bin Meng @ 2017-11-20  7:07 UTC (permalink / raw)
  To: u-boot

On Wed, Nov 15, 2017 at 1:47 AM, Anton Gerasimov
<anton@advancedtelematic.com> wrote:
> ROM has been made read-only in qemu recently (namely commit
> 208fa0e43645edd0b0d8f838857dfc79daff40a8), so this patch restores
> compatibility between u-boot and qemu.
>
> Signed-off-by: Anton Gerasimov <anton@advancedtelematic.com>
> ---
>  arch/x86/cpu/qemu/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Tested-by: Bin Meng <bmeng.cn@gmail.com>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [U-Boot] [PATCH] Move Cache-As-RAM memory from area mapped to ROM in QEMU
  2017-11-20  7:07 ` Bin Meng
@ 2017-11-20  9:15   ` Bin Meng
  0 siblings, 0 replies; 8+ messages in thread
From: Bin Meng @ 2017-11-20  9:15 UTC (permalink / raw)
  To: u-boot

On Mon, Nov 20, 2017 at 3:07 PM, Bin Meng <bmeng.cn@gmail.com> wrote:
> On Wed, Nov 15, 2017 at 1:47 AM, Anton Gerasimov
> <anton@advancedtelematic.com> wrote:
>> ROM has been made read-only in qemu recently (namely commit
>> 208fa0e43645edd0b0d8f838857dfc79daff40a8), so this patch restores
>> compatibility between u-boot and qemu.
>>
>> Signed-off-by: Anton Gerasimov <anton@advancedtelematic.com>
>> ---
>>  arch/x86/cpu/qemu/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> Tested-by: Bin Meng <bmeng.cn@gmail.com>

Adjusted the commit tile to add the "x86: qemu" tags, mentioned qemu
commit tile in the commit message, and

applied to u-boot-x86, thanks!

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2017-11-20  9:15 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-10 17:51 [U-Boot] [PATCH] Move Cache-As-RAM memory from area mapped to ROM in QEMU Anton Gerasimov
2017-11-10 22:49 ` Tom Rini
2017-11-11 11:08 ` [U-Boot] " Heinrich Schuchardt
2017-11-13 10:23   ` Anton Gerasimov
2017-11-14 17:32     ` Heinrich Schuchardt
  -- strict thread matches above, loose matches on Subject: below --
2017-11-14 17:47 [U-Boot] [PATCH] " Anton Gerasimov
2017-11-20  7:07 ` Bin Meng
2017-11-20  9:15   ` Bin Meng

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox