From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Fri, 17 Nov 2017 10:12:54 +0100 Subject: [U-Boot] [RFC PATCH 01/10] cmd: nvedit: Get rid of the env lookup In-Reply-To: <20171116092231.27740-2-maxime.ripard@free-electrons.com> References: <20171116092231.27740-1-maxime.ripard@free-electrons.com> <20171116092231.27740-2-maxime.ripard@free-electrons.com> Message-ID: <20171117101254.3dcf0200@jawa> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, 16 Nov 2017 10:22:22 +0100 Maxime Ripard wrote: > The nvedit command is the only user of env_driver_lookup_default > outside of the environment code itself, and it uses it only to print > the environment it's about to save to during env save. > > As we're about to rework the environment to be able to handle multiple > environment sources, we might not have an idea of what environment > backend is going to be used before trying (and possibly failing for > some). > > Therefore, it makes sense to remove that message and move it to the > env_save function itself. As a side effect, we also can get rid of > the call to env_driver_lookup default that is also about to get > refactored. > > Signed-off-by: Maxime Ripard > --- > cmd/nvedit.c | 4 ---- > env/env.c | 2 ++ > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/cmd/nvedit.c b/cmd/nvedit.c > index 4e79d03856fe..a690d743cd46 100644 > --- a/cmd/nvedit.c > +++ b/cmd/nvedit.c > @@ -708,10 +708,6 @@ ulong env_get_ulong(const char *name, int base, > ulong default_val) static int do_env_save(cmd_tbl_t *cmdtp, int flag, > int argc, char * const argv[]) > { > - struct env_driver *env = env_driver_lookup_default(); > - > - printf("Saving Environment to %s...\n", env->name); > - > return env_save() ? 1 : 0; > } > > diff --git a/env/env.c b/env/env.c > index 76a5608628fc..84c12e27bc3f 100644 > --- a/env/env.c > +++ b/env/env.c > @@ -115,6 +115,8 @@ int env_save(void) > return -ENODEV; > if (!drv->save) > return -ENOSYS; > + > + printf("Saving Environment to %s...\n", drv->name); > ret = drv->save(); > if (ret) { > debug("%s: Environment failed to save (err=%d)\n", > __func__, Reviewed-by: Lukasz Majewski Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: