From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH 02/10] env: Make env_driver_lookup_default private
Date: Fri, 17 Nov 2017 10:13:24 +0100 [thread overview]
Message-ID: <20171117101324.742a94f4@jawa> (raw)
In-Reply-To: <20171116092231.27740-3-maxime.ripard@free-electrons.com>
On Thu, 16 Nov 2017 10:22:23 +0100
Maxime Ripard <maxime.ripard@free-electrons.com> wrote:
> No that there's no users of env_driver_lookup_default outside of
> env/env.c, we can mark that function static and remove it from the
> environment header.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
> env/env.c | 2 +-
> include/environment.h | 7 -------
> 2 files changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/env/env.c b/env/env.c
> index 84c12e27bc3f..094538ff5b62 100644
> --- a/env/env.c
> +++ b/env/env.c
> @@ -52,7 +52,7 @@ static enum env_location
> env_get_default_location(void) return ENVL_UNKNOWN;
> }
>
> -struct env_driver *env_driver_lookup_default(void)
> +static struct env_driver *env_driver_lookup_default(void)
> {
> enum env_location loc = env_get_default_location();
> struct env_driver *drv;
> diff --git a/include/environment.h b/include/environment.h
> index 7b9821638960..226e3ef2d23a 100644
> --- a/include/environment.h
> +++ b/include/environment.h
> @@ -302,13 +302,6 @@ int env_export(env_t *env_out);
> int env_import_redund(const char *buf1, const char *buf2);
> #endif
>
> -/**
> - * env_driver_lookup_default() - Look up the default environment
> driver
> - *
> - * @return pointer to driver, or NULL if none (which should not
> happen)
> - */
> -struct env_driver *env_driver_lookup_default(void);
> -
> /**
> * env_get_char() - Get a character from the early environment
> *
Reviewed-by: Lukasz Majewski <lukma@denx.de>
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 484 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171117/f6b4426f/attachment.sig>
next prev parent reply other threads:[~2017-11-17 9:13 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 9:22 [U-Boot] [RFC PATCH 00/10] env: Multiple env support and env transition for sunxi Maxime Ripard
2017-11-16 9:22 ` [U-Boot] [RFC PATCH 01/10] cmd: nvedit: Get rid of the env lookup Maxime Ripard
2017-11-17 9:12 ` Lukasz Majewski
2017-11-16 9:22 ` [U-Boot] [RFC PATCH 02/10] env: Make env_driver_lookup_default private Maxime Ripard
2017-11-17 9:13 ` Lukasz Majewski [this message]
2017-11-20 9:53 ` Andre Przywara
2017-11-16 9:22 ` [U-Boot] [RFC PATCH 03/10] env: Rename env_driver_lookup_default and env_get_default_location Maxime Ripard
2017-11-17 9:14 ` Lukasz Majewski
2017-11-16 9:22 ` [U-Boot] [RFC PATCH 04/10] env: Pass additional parameters to the env lookup function Maxime Ripard
2017-11-17 9:19 ` Lukasz Majewski
2017-11-24 9:20 ` Quentin Schulz
2017-11-16 9:22 ` [U-Boot] [RFC PATCH 05/10] env: Make the env save message a bit more explicit Maxime Ripard
2017-11-17 9:20 ` Lukasz Majewski
2017-11-16 9:22 ` [U-Boot] [RFC PATCH 06/10] env: Support multiple environments Maxime Ripard
2017-11-17 9:24 ` Lukasz Majewski
2017-11-17 13:41 ` Tom Rini
2017-11-17 14:00 ` Lukasz Majewski
2017-11-17 14:19 ` Maxime Ripard
2017-11-17 14:40 ` Lukasz Majewski
2017-11-17 17:07 ` Maxime Ripard
2017-11-16 9:22 ` [U-Boot] [RFC PATCH 07/10] env: Allow to build multiple environments in Kconfig Maxime Ripard
2017-11-17 9:25 ` Lukasz Majewski
2017-11-16 9:22 ` [U-Boot] [RFC PATCH 08/10] env: Mark env_get_location as weak Maxime Ripard
2017-11-17 9:26 ` Lukasz Majewski
2017-11-16 9:22 ` [U-Boot] [RFC PATCH 09/10] sunxi: Transition from the MMC to a FAT-based environment Maxime Ripard
2017-11-17 9:27 ` Lukasz Majewski
2017-11-16 9:22 ` [U-Boot] [RFC PATCH 10/10] env: sunxi: Enable FAT-based environment support by default Maxime Ripard
2017-11-17 9:27 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171117101324.742a94f4@jawa \
--to=lukma@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox