From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Fri, 17 Nov 2017 10:20:50 +0100 Subject: [U-Boot] [RFC PATCH 05/10] env: Make the env save message a bit more explicit In-Reply-To: <20171116092231.27740-6-maxime.ripard@free-electrons.com> References: <20171116092231.27740-1-maxime.ripard@free-electrons.com> <20171116092231.27740-6-maxime.ripard@free-electrons.com> Message-ID: <20171117102050.2bb72b37@jawa> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, 16 Nov 2017 10:22:26 +0100 Maxime Ripard wrote: > Since we'll soon have support for multiple environments, the > environment saving message might end up being printed multiple times > if the higher priority environment cannot be used. > > That might confuse the user, so let's make it explicit if the > operation failed or not. > > Signed-off-by: Maxime Ripard > --- > env/env.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/env/env.c b/env/env.c > index 673bfa6ba41b..1d13220aa79b 100644 > --- a/env/env.c > +++ b/env/env.c > @@ -131,8 +131,9 @@ int env_save(void) > if (!drv->save) > continue; > > - printf("Saving Environment to %s...\n", drv->name); > + printf("Saving Environment to %s... ", drv->name); > ret = drv->save(); > + printf("%s\n", ret ? "Failed" : "OK"); > if (!ret) > return 0; > Reviewed-by: Lukasz Majewski Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: