U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] mmc1 not working on Samsung snow chromebook
Date: Fri, 17 Nov 2017 10:36:08 +0100	[thread overview]
Message-ID: <20171117103608.2dc24c55@jawa> (raw)
In-Reply-To: <aca6074b-b466-a517-3e29-2817c73a0329@free.fr>

On Thu, 16 Nov 2017 13:29:56 +0100
Guillaume Gardet <guillaume.gardet@free.fr> wrote:

> I found a workaround. If I disable MMC_MODE_HS_52MHz, then it is
> working fine.
> 
> I guess there is a better way to implement the following patch ?
> 
> **********************************************************************
> diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c
> index 23f642980b..a6a0934eef 100644
> --- a/drivers/mmc/dw_mmc.c
> +++ b/drivers/mmc/dw_mmc.c
> @@ -508,7 +508,8 @@ void dwmci_setup_cfg(struct mmc_config *cfg,
> struct dwmci_host *host, cfg->host_caps |= MMC_MODE_4BIT;
>                  cfg->host_caps &= ~MMC_MODE_8BIT;
>          }
> -       cfg->host_caps |= MMC_MODE_HS | MMC_MODE_HS_52MHz;
> +       /* MMC_MODE_HS_52MHz is broken (at least) on Samsung Snow, so
> disbale it for now */
> +       cfg->host_caps |= MMC_MODE_HS;

This seems like a workaround. The root cause of the problem is the
regression with HS 52MHz....

> 
>          cfg->b_max = CONFIG_SYS_MMC_MAX_BLK_COUNT;
>   }
> **********************************************************************
> 
> 
> Guillaume
> 
> 
> 
> Le 15/11/2017 à 11:27, Guillaume Gardet a écrit :
> >
> >
> > Le 15/11/2017 à 11:22, Guillaume Gardet a écrit :  
> >> Forgot to Cc ML. Done now.
> >>
> >>
> >> Le 15/11/2017 à 11:14, Guillaume Gardet a écrit :  
> >>> Hello,
> >>>
> >>> I tested U-Boot v2017.09 on a Samsung Snow (Chromebook ARM) and
> >>> while mmc0 (internal eMMC) is working fine, mmc1 (external SD
> >>> slot) does not work. I get the following error for 'mmc dev 1'
> >>> command: mmc_init: -110, time 30  
> >
> > Please also note that on boot (or on 1st 'mmc dev 1' cmd if I stop
> > auto-boot), I firstly get: mmc_init: -5, time 39
> >
> > Then, all next attempts retruns:
> >     mmc_init: -110, time 30
> >
> >
> > Guillaume
> >
> >  
> >>>
> >>> Any idea what could be wrong?
> >>>
> >>> Guillaume
> >>>
> >>>  
> >>  
> >  
> 
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot



Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171117/9841f9dd/attachment.sig>

  reply	other threads:[~2017-11-17  9:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <b80237e1-85e3-d327-6f0a-6277e1ecd251@free.fr>
2017-11-15 10:22 ` [U-Boot] mmc1 not working on Samsung snow chromebook Guillaume Gardet
2017-11-15 10:27   ` Guillaume Gardet
2017-11-16 12:29     ` Guillaume Gardet
2017-11-17  9:36       ` Lukasz Majewski [this message]
2017-11-17  9:38         ` Guillaume Gardet
2017-11-17 16:06           ` Jaehoon Chung
2017-11-18 16:33             ` Guillaume Gardet
2017-12-01 12:42               ` Guillaume Gardet
2017-11-17  9:48       ` Jaehoon Chung
2018-01-09 14:37         ` Guillaume Gardet
2018-01-17 10:05           ` Jaehoon Chung
2018-01-18  9:05             ` Guillaume Gardet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171117103608.2dc24c55@jawa \
    --to=lukma@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox