From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] serial: nulldev: Implement "pending" function to fix tstc return "true"
Date: Fri, 17 Nov 2017 10:44:55 -0500 [thread overview]
Message-ID: <20171117154455.GP9986@bill-the-cat> (raw)
In-Reply-To: <1509691191-3850-1-git-send-email-wilson.lee@ni.com>
On Thu, Nov 02, 2017 at 11:39:51PM -0700, Wilson Lee wrote:
> In U-boot, serial_tstc was use to determine is there have a character in
> serial console that pending for read. If there is no "pending" function
> implemented in serial driver, the serial-uclass will return "true(1)"
> to indicate there have a character pending to read.
>
> Thus, read a character from nulldev serial will result in continuous
> getting -EAGAIN return which might lead system to hang.
>
> This commit is to fix a bug in nulldev serial which implement "pending"
> function in nulldev serial to always indicate there is no character in
> console that pending for read.
>
> Signed-off-by: Wilson Lee <wilson.lee@ni.com>
> Cc: Joe Hershberger <joe.hershberger@ni.com>
> Cc: Keng Soon Cheah <keng.soon.cheah@ni.com>
> Cc: Chen Yee Chew <chen.yee.chew@ni.com>
> Cc: Bin Meng <bmeng.cn@gmail.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171117/26ca3459/attachment.sig>
prev parent reply other threads:[~2017-11-17 15:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-03 6:39 [U-Boot] [PATCH] serial: nulldev: Implement "pending" function to fix tstc return "true" Wilson Lee
2017-11-17 15:44 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171117154455.GP9986@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox