* [U-Boot] [PATCH] arm: config: fix default console only to specify the device
@ 2017-10-28 4:22 tobetter at gmail.com
2017-11-10 5:16 ` Simon Glass
2017-11-17 19:08 ` [U-Boot] " Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: tobetter at gmail.com @ 2017-10-28 4:22 UTC (permalink / raw)
To: u-boot
From: Dongjin Kim <tobetter@gmail.com>
Since CONFIG_DEFAULT_CONSOLE is already started with "console=",
the console argument in CONFIG_EXTRA_ENV_SETTINGS is expanded to
"console=console=ttySAC1,115200n8" and this causes the wrong
console device.
#define CONFIG_DEFAULT_CONSOLE "console=ttySAC1,115200n8\0"
...
#define CONFIG_EXTRA_ENV_SETTINGS \
"console=" CONFIG_DEFAULT_CONSOLE
Signed-off-by: Dongjin Kim <tobetter@gmail.com>
---
include/configs/odroid.h | 4 ++--
include/configs/odroid_xu3.h | 4 ++--
include/configs/s5p_goni.h | 4 ++--
include/configs/s5pc210_universal.h | 4 ++--
include/configs/trats.h | 4 ++--
include/configs/trats2.h | 4 ++--
6 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/include/configs/odroid.h b/include/configs/odroid.h
index 22e9c82497..60ed013959 100644
--- a/include/configs/odroid.h
+++ b/include/configs/odroid.h
@@ -44,7 +44,7 @@
/* Console configuration */
#define CONFIG_BOOTCOMMAND "run autoboot"
-#define CONFIG_DEFAULT_CONSOLE "console=ttySAC1,115200n8\0"
+#define CONFIG_DEFAULT_CONSOLE "ttySAC1,115200n8"
#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_LOAD_ADDR \
- GENERATED_GBL_DATA_SIZE)
@@ -158,7 +158,7 @@
"elif test -e mmc 0 uImage; then; " \
"run boot_uimg;" \
"fi;\0" \
- "console=" CONFIG_DEFAULT_CONSOLE \
+ "console=" CONFIG_DEFAULT_CONSOLE "\0" \
"mmcbootdev=0\0" \
"mmcbootpart=1\0" \
"mmcrootdev=0\0" \
diff --git a/include/configs/odroid_xu3.h b/include/configs/odroid_xu3.h
index 13a45010bf..2969f18993 100644
--- a/include/configs/odroid_xu3.h
+++ b/include/configs/odroid_xu3.h
@@ -34,7 +34,7 @@
#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_LOAD_ADDR - 0x1000000)
-#define CONFIG_DEFAULT_CONSOLE "console=ttySAC2,115200n8\0"
+#define CONFIG_DEFAULT_CONSOLE "ttySAC2,115200n8"
/* USB */
#define CONFIG_USB_EHCI_EXYNOS
@@ -108,7 +108,7 @@
BOOTENV \
"bootdelay=0\0" \
"rootfstype=ext4\0" \
- "console=" CONFIG_DEFAULT_CONSOLE \
+ "console=" CONFIG_DEFAULT_CONSOLE "\0"\
"fdtfile=exynos5422-odroidxu3.dtb\0" \
"boardname=odroidxu3\0" \
"mmcbootdev=0\0" \
diff --git a/include/configs/s5p_goni.h b/include/configs/s5p_goni.h
index 7a6eed4ea8..f7bd4630b6 100644
--- a/include/configs/s5p_goni.h
+++ b/include/configs/s5p_goni.h
@@ -104,7 +104,7 @@
#define CONFIG_BOOTCOMMAND "run mmcboot"
-#define CONFIG_DEFAULT_CONSOLE "console=ttySAC2,115200n8\0"
+#define CONFIG_DEFAULT_CONSOLE "ttySAC2,115200n8"
#define CONFIG_RAMDISK_BOOT "root=/dev/ram0 rw rootfstype=ext4" \
" ${console} ${meminfo}"
@@ -154,7 +154,7 @@
"bootchart=set opts init=/sbin/bootchartd; run bootcmd\0" \
"verify=n\0" \
"rootfstype=ext4\0" \
- "console=" CONFIG_DEFAULT_CONSOLE \
+ "console=" CONFIG_DEFAULT_CONSOLE "\0"\
"meminfo=mem=80M mem=256M at 0x40000000 mem=128M at 0x50000000\0" \
"loaduimage=ext4load mmc ${mmcdev}:${mmcbootpart} 0x30007FC0 uImage\0" \
"mmcdev=0\0" \
diff --git a/include/configs/s5pc210_universal.h b/include/configs/s5pc210_universal.h
index 7ecaefbc8c..d1dbee2407 100644
--- a/include/configs/s5pc210_universal.h
+++ b/include/configs/s5pc210_universal.h
@@ -30,7 +30,7 @@
/* Console configuration */
#define CONFIG_BOOTCOMMAND "run mmcboot"
-#define CONFIG_DEFAULT_CONSOLE "console=ttySAC1,115200n8\0"
+#define CONFIG_DEFAULT_CONSOLE "ttySAC1,115200n8"
#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_LOAD_ADDR \
- GENERATED_GBL_DATA_SIZE)
@@ -132,7 +132,7 @@
"mmcoops=mmc read 0 0x40000000 0x40 8; md 0x40000000 0x400\0" \
"verify=n\0" \
"rootfstype=ext4\0" \
- "console=" CONFIG_DEFAULT_CONSOLE \
+ "console=" CONFIG_DEFAULT_CONSOLE "\0" \
"mtdparts=" MTDPARTS_DEFAULT \
"mbrparts=" MBRPARTS_DEFAULT \
"meminfo=crashkernel=32M at 0x50000000\0" \
diff --git a/include/configs/trats.h b/include/configs/trats.h
index a34c349bb3..b97efc21cd 100644
--- a/include/configs/trats.h
+++ b/include/configs/trats.h
@@ -42,7 +42,7 @@
#define CONFIG_MACH_TYPE MACH_TYPE_TRATS
#define CONFIG_BOOTCOMMAND "run autoboot"
-#define CONFIG_DEFAULT_CONSOLE "console=ttySAC2,115200n8\0"
+#define CONFIG_DEFAULT_CONSOLE "ttySAC2,115200n8"
#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_LOAD_ADDR \
- GENERATED_GBL_DATA_SIZE)
@@ -129,7 +129,7 @@
"mmcoops=mmc read 0 0x40000000 0x40 8; md 0x40000000 0x400\0" \
"verify=n\0" \
"rootfstype=ext4\0" \
- "console=" CONFIG_DEFAULT_CONSOLE \
+ "console=" CONFIG_DEFAULT_CONSOLE "\0" \
"meminfo=crashkernel=32M at 0x50000000\0" \
"nfsroot=/nfsroot/arm\0" \
"bootblock=" CONFIG_BOOTBLOCK "\0" \
diff --git a/include/configs/trats2.h b/include/configs/trats2.h
index 6b371f4ab9..871accf791 100644
--- a/include/configs/trats2.h
+++ b/include/configs/trats2.h
@@ -39,7 +39,7 @@
/* Console configuration */
#define CONFIG_BOOTCOMMAND "run autoboot"
-#define CONFIG_DEFAULT_CONSOLE "console=ttySAC2,115200n8\0"
+#define CONFIG_DEFAULT_CONSOLE "ttySAC2,115200n8"
#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_LOAD_ADDR \
- GENERATED_GBL_DATA_SIZE)
@@ -111,7 +111,7 @@
"boottrace=setenv opts initcall_debug; run bootcmd\0" \
"verify=n\0" \
"rootfstype=ext4\0" \
- "console=" CONFIG_DEFAULT_CONSOLE \
+ "console=" CONFIG_DEFAULT_CONSOLE "\0" \
"kernelname=uImage\0" \
"loaduimage=ext4load mmc ${mmcdev}:${mmcbootpart} 0x40007FC0 " \
"${kernelname}\0" \
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* [U-Boot] [PATCH] arm: config: fix default console only to specify the device
2017-10-28 4:22 [U-Boot] [PATCH] arm: config: fix default console only to specify the device tobetter at gmail.com
@ 2017-11-10 5:16 ` Simon Glass
2017-11-17 19:08 ` [U-Boot] " Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2017-11-10 5:16 UTC (permalink / raw)
To: u-boot
On 27 October 2017 at 22:22, <tobetter@gmail.com> wrote:
> From: Dongjin Kim <tobetter@gmail.com>
>
> Since CONFIG_DEFAULT_CONSOLE is already started with "console=",
> the console argument in CONFIG_EXTRA_ENV_SETTINGS is expanded to
> "console=console=ttySAC1,115200n8" and this causes the wrong
> console device.
>
> #define CONFIG_DEFAULT_CONSOLE "console=ttySAC1,115200n8\0"
> ...
> #define CONFIG_EXTRA_ENV_SETTINGS \
> "console=" CONFIG_DEFAULT_CONSOLE
>
> Signed-off-by: Dongjin Kim <tobetter@gmail.com>
> ---
> include/configs/odroid.h | 4 ++--
> include/configs/odroid_xu3.h | 4 ++--
> include/configs/s5p_goni.h | 4 ++--
> include/configs/s5pc210_universal.h | 4 ++--
> include/configs/trats.h | 4 ++--
> include/configs/trats2.h | 4 ++--
> 6 files changed, 12 insertions(+), 12 deletions(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] arm: config: fix default console only to specify the device
2017-10-28 4:22 [U-Boot] [PATCH] arm: config: fix default console only to specify the device tobetter at gmail.com
2017-11-10 5:16 ` Simon Glass
@ 2017-11-17 19:08 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2017-11-17 19:08 UTC (permalink / raw)
To: u-boot
On Sat, Oct 28, 2017 at 12:22:27AM -0400, tobetter at gmail.com wrote:
> From: Dongjin Kim <tobetter@gmail.com>
>
> Since CONFIG_DEFAULT_CONSOLE is already started with "console=",
> the console argument in CONFIG_EXTRA_ENV_SETTINGS is expanded to
> "console=console=ttySAC1,115200n8" and this causes the wrong
> console device.
>
> #define CONFIG_DEFAULT_CONSOLE "console=ttySAC1,115200n8\0"
> ...
> #define CONFIG_EXTRA_ENV_SETTINGS \
> "console=" CONFIG_DEFAULT_CONSOLE
>
> Signed-off-by: Dongjin Kim <tobetter@gmail.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171117/48f03467/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-17 19:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-28 4:22 [U-Boot] [PATCH] arm: config: fix default console only to specify the device tobetter at gmail.com
2017-11-10 5:16 ` Simon Glass
2017-11-17 19:08 ` [U-Boot] " Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox