From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Wed, 22 Nov 2017 10:09:41 +0100 Subject: [U-Boot] [PATCH 5/5] mmc: all hosts support 1-bit bus width and legacy timings In-Reply-To: <1511277188-2923-6-git-send-email-jjhiblot@ti.com> References: <1511277188-2923-1-git-send-email-jjhiblot@ti.com> <1511277188-2923-6-git-send-email-jjhiblot@ti.com> Message-ID: <20171122100941.73ced5b2@jawa> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, 21 Nov 2017 16:13:08 +0100 Jean-Jacques Hiblot wrote: > Make sure that those basic capabilities are advertised by the host. > > Signed-off-by: Jean-Jacques Hiblot > --- > drivers/mmc/mmc.c | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c > index 67f21ff..ec1dc49 100644 > --- a/drivers/mmc/mmc.c > +++ b/drivers/mmc/mmc.c > @@ -1587,10 +1587,10 @@ static int sd_select_mode_and_width(struct > mmc *mmc, uint card_caps) uint caps; > > mmc_dump_capabilities("sd card", card_caps); > - mmc_dump_capabilities("host", mmc->host_caps | > MMC_MODE_1BIT); > + mmc_dump_capabilities("host", mmc->host_caps); > > /* Restrict card's capabilities by what the host can do */ > - caps = card_caps & (mmc->host_caps | MMC_MODE_1BIT); > + caps = card_caps & mmc->host_caps; > > if (!uhs_en) > caps &= ~UHS_CAPS; > @@ -1771,10 +1771,10 @@ static int mmc_select_mode_and_width(struct > mmc *mmc, uint card_caps) const struct ext_csd_bus_width *ecbw; > > mmc_dump_capabilities("mmc", card_caps); > - mmc_dump_capabilities("host", mmc->host_caps | > MMC_MODE_1BIT); > + mmc_dump_capabilities("host", mmc->host_caps); > > /* Restrict card's capabilities by what the host can do */ > - card_caps &= (mmc->host_caps | MMC_MODE_1BIT); > + card_caps &= mmc->host_caps; > > /* Only version 4 of MMC supports wider bus widths */ > if (mmc->version < MMC_VERSION_4) > @@ -2389,7 +2389,12 @@ int mmc_start_init(struct mmc *mmc) > bool uhs_en = supports_uhs(mmc->cfg->host_caps); > int err; > > - mmc->host_caps = mmc->cfg->host_caps; > + /* > + * all hosts are capable of 1 bit bus-width and able to use > the legacy > + * timings. > + */ > + mmc->host_caps = mmc->cfg->host_caps | MMC_CAP(SD_LEGACY) | > + MMC_CAP(MMC_LEGACY) | MMC_MODE_1BIT; > > /* we pretend there's no card when init is NULL */ > no_card = mmc_getcd(mmc) == 0; Reviewed-by: Lukasz Majewski Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: