public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] test/run: Exit on error from tests
Date: Mon, 27 Nov 2017 20:11:45 -0500	[thread overview]
Message-ID: <20171128011145.GT3587@bill-the-cat> (raw)
In-Reply-To: <CAPnjgZ2-kJKPdOTmv20pGiuahCa0w8dztVFuc-gaHipeJS=6HQ@mail.gmail.com>

On Mon, Nov 27, 2017 at 02:45:14PM -0700, Simon Glass wrote:
> Hi Tom,
> 
> On 27 November 2017 at 14:21, Tom Rini <trini@konsulko.com> wrote:
> > Currently, result isn't saved outside of the scope of run_test, so we
> > always exit on error here.  An easier way to deal with having test/run
> > show failures is to exit on failure.
> >
> > Cc: Simon Glass <sjg@chromium.org>
> > Fixes: 2f52018c3cbb ("test/run: Report and return failure")
> > Signed-off-by: Tom Rini <trini@konsulko.com>
> > ---
> > Automation is only as good as the humans behind it.  If you forget, like
> > I did, that you finally fixed Jenkins to email you every time, that lack
> > of emails about my non-travis jobs failing wasn't "no problems", it was
> > "You forgot to migrate all the Docker stuff to the new build server".
> > So, I'm going to apply this ASAP as I would not have let in the
> > u-boot-dm PR, had my setup been functioning as expected.
> > ---
> >  test/run | 18 ++++--------------
> >  1 file changed, 4 insertions(+), 14 deletions(-)
> 
> I'm OK with this if it's what you want. This means that we will not
> run all the tests if one of the earlier one fails.
> 
> Did you see this one?
> 
> http://patchwork.ozlabs.org/patch/841453/

I'm playing a little catch-up and that's fine too.  I've unearthed
another bit of breakage to fix now (because the time PRs break my setup
is the time I break runtime of my setup and assume it's working).

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171127/dd53b42d/attachment.sig>

  reply	other threads:[~2017-11-28  1:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-27 21:21 [U-Boot] [PATCH] test/run: Exit on error from tests Tom Rini
2017-11-27 21:45 ` Simon Glass
2017-11-28  1:11   ` Tom Rini [this message]
2017-11-28  4:32     ` Simon Glass
2017-11-28 14:33       ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171128011145.GT3587@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox