From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Date: Tue, 28 Nov 2017 15:13:04 +0100 Subject: [U-Boot] [RFC] Support for SGMII 2500 In-Reply-To: References: <20171128133029.GB20797@lunn.ch> Message-ID: <20171128141304.GE20797@lunn.ch> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de > Hi Andrew, > > Bhaskar is working on enabling a PFE [1] MAC connected to an Aquantia AQR107 > PHY [2] on a LS1012AQDS board. Initially I've indicated 2500Base-X too, but it > seems the HW actually works in SGMII mode. The QDS boards are lower volume, > higher spec boards than the RDBs [3], they exercise most of the HW capabilities. The webpage for the AQR107 lists 2500Base-X, so i assume the issue is with the MAC? Ideally you want to use 2500Base-X, since this is wider known. Anyway, you seem to have a legitimate need for it. However, i would prefer a different name. The convention is to put the number first. So PHY_INTERFACE_MODE_2500SGMII. Andrew