From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Tue, 28 Nov 2017 09:33:29 -0500 Subject: [U-Boot] [PATCH] test/run: Exit on error from tests In-Reply-To: References: <1511817671-4025-1-git-send-email-trini@konsulko.com> <20171128011145.GT3587@bill-the-cat> Message-ID: <20171128143329.GD3587@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Nov 27, 2017 at 09:32:06PM -0700, Simon Glass wrote: > Hi Tom, > > On 27 November 2017 at 18:11, Tom Rini wrote: > > On Mon, Nov 27, 2017 at 02:45:14PM -0700, Simon Glass wrote: > >> Hi Tom, > >> > >> On 27 November 2017 at 14:21, Tom Rini wrote: > >> > Currently, result isn't saved outside of the scope of run_test, so we > >> > always exit on error here. An easier way to deal with having test/run > >> > show failures is to exit on failure. > >> > > >> > Cc: Simon Glass > >> > Fixes: 2f52018c3cbb ("test/run: Report and return failure") > >> > Signed-off-by: Tom Rini > >> > --- > >> > Automation is only as good as the humans behind it. If you forget, like > >> > I did, that you finally fixed Jenkins to email you every time, that lack > >> > of emails about my non-travis jobs failing wasn't "no problems", it was > >> > "You forgot to migrate all the Docker stuff to the new build server". > >> > So, I'm going to apply this ASAP as I would not have let in the > >> > u-boot-dm PR, had my setup been functioning as expected. > >> > --- > >> > test/run | 18 ++++-------------- > >> > 1 file changed, 4 insertions(+), 14 deletions(-) > >> > >> I'm OK with this if it's what you want. This means that we will not > >> run all the tests if one of the earlier one fails. > >> > >> Did you see this one? > >> > >> http://patchwork.ozlabs.org/patch/841453/ > > > > I'm playing a little catch-up and that's fine too. I've unearthed > > another bit of breakage to fix now (because the time PRs break my setup > > is the time I break runtime of my setup and assume it's working). > > Yes, OK, sorry about the churn. As you can tell I'm trying to get it > so all the tests we have run automatically both with 'make tests' and > with travis-ci. Still a way to go but it is closer. I'm looking forward to it all being in there :) Thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: