public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 07/10] mmc: allow to compile out the error messages
Date: Wed, 29 Nov 2017 13:43:11 -0500	[thread overview]
Message-ID: <20171129184311.GY3587@bill-the-cat> (raw)
In-Reply-To: <1511965794-24118-8-git-send-email-jjhiblot@ti.com>

On Wed, Nov 29, 2017 at 03:29:52PM +0100, Jean-Jacques Hiblot wrote:

> Error messages may not be as valued as code space. Allow to compile out
> most of them to free space.
> 
> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
> ---
>  drivers/mmc/Kconfig |  1 +
>  drivers/mmc/mmc.c   | 44 ++++++++++++++++++++------------------------
>  2 files changed, 21 insertions(+), 24 deletions(-)
> 
> diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig
> index dbbef5a..7a45d4b 100644
> --- a/drivers/mmc/Kconfig
> +++ b/drivers/mmc/Kconfig
> @@ -60,6 +60,7 @@ config MMC_VERBOSE
>  
>  config SPL_MMC_VERBOSE
>  	bool "Output more information about the MMC in SPL"
> +	depends on SPL_LIBCOMMON_SUPPORT
>  	default n
>  	help
>  	  Enable the output of more information about the card such as the
> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
> index 13979a5..af303b3 100644
> --- a/drivers/mmc/mmc.c
> +++ b/drivers/mmc/mmc.c
> @@ -22,6 +22,12 @@
>  #include <div64.h>
>  #include "mmc_private.h"
>  
> +#if CONFIG_IS_ENABLED(MMC_VERBOSE)
> +#define error printf
> +#else
> +#define error(...)
> +#endif

Lets switch to pr_XXX so that we can make use of the normal log level
tweaking to keep / drop these, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171129/62f32748/attachment.sig>

  reply	other threads:[~2017-11-29 18:43 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-29 14:29 [U-Boot] [PATCH v4 00/10] mmc: fixes for HS200/UHS core support Jean-Jacques Hiblot
2017-11-29 14:29 ` [U-Boot] [PATCH v4 01/10] mmc: dump card and host capabilities if debug is enabled Jean-Jacques Hiblot
2017-12-02  3:29   ` Simon Glass
2017-11-29 14:29 ` [U-Boot] [PATCH v4 02/10] dm: mmc: update mmc_of_parse() Jean-Jacques Hiblot
2017-12-02  3:29   ` Simon Glass
2017-11-29 14:29 ` [U-Boot] [PATCH v4 03/10] mmc: Fixed a problem with old sd or mmc that do not support High speed Jean-Jacques Hiblot
2017-11-29 14:29 ` [U-Boot] [PATCH v4 04/10] mmc: all hosts support 1-bit bus width and legacy timings Jean-Jacques Hiblot
2017-11-29 14:29 ` [U-Boot] [PATCH v4 05/10] mmc: fix for old MMCs (below version 4) Jean-Jacques Hiblot
2017-12-02  3:29   ` Simon Glass
2017-11-29 14:29 ` [U-Boot] [PATCH v4 06/10] mmc: don't use malloc_cache_aligned() Jean-Jacques Hiblot
2017-12-02  3:29   ` Simon Glass
2017-11-29 14:29 ` [U-Boot] [PATCH v4 07/10] mmc: allow to compile out the error messages Jean-Jacques Hiblot
2017-11-29 18:43   ` Tom Rini [this message]
2017-11-29 14:29 ` [U-Boot] [PATCH v4 08/10] mmc: make UHS and HS200 optional Jean-Jacques Hiblot
2017-12-02  3:29   ` Simon Glass
2017-12-06  8:29     ` Jean-Jacques Hiblot
2017-11-29 14:29 ` [U-Boot] [PATCH v4 09/10] mmc: make optional the support for eMMMC hardware partitioning Jean-Jacques Hiblot
2017-11-29 18:44   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171129184311.GY3587@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox