[U-Boot] [RFC PATCH 09/13] arm: nexell: add UART support

Simon Glass
2017-12-02T03:31:17Z

On 29 November 2017 at 18:25, Andre Przywara <andre.przywara@arm.com> wrote:
> The Nexell S5P6818 SoC uses a UART very similar to those used in the
> Samsung S5P SoCs.
> Enable the driver in the config and add the necessary glue headers
> and clock functions to make the S5P driver happy.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> ---
> arch/arm/Kconfig | 3 ++
> arch/arm/include/asm/arch-nexell/clk.h | 13 +++++++++
> arch/arm/mach-nexell/board.c | 50 ++++++++++++++++++++++++++++++++++
> 3 files changed, 66 insertions(+)
> create mode 100644 arch/arm/include/asm/arch-nexell/clk.h

Reviewed-by: Simon Glass <sjg@chromium.org>

Q below

>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index b0f3ee7289..9c317ddf3f 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -656,6 +656,9 @@ config ARCH_NEXELL
> bool "Nexell S5P support"
> select ARM64
> select ENABLE_ARM_SOC_BOOT0_HOOK
> + select DM
> + select DM_SERIAL
> + select SAMSUNG_UART
>
> config ARCH_QEMU
> bool "QEMU Virtual Platform"
> diff --git a/arch/arm/include/asm/arch-nexell/clk.h b/arch/arm/include/asm/arch-nexell/clk.h
> new file mode 100644
> index 0000000000..bfd145f555
> --- /dev/null
> +++ b/arch/arm/include/asm/arch-nexell/clk.h
> @@ -0,0 +1,13 @@
> +/*
> + * (C) Copyright 2017 ARM Ltd.
> + * Andre Przywara <andre.przywara@arm.com>
> + *
> + * SPDX-License-Identifier: GPL-2.0+
> + */
> +
> +#ifndef __ASM_ARCH_CLK_H_
> +#define __ASM_ARCH_CLK_H_
> +
> +unsigned long get_uart_clk(int dev_index);
> +
> +#endif
> diff --git a/arch/arm/mach-nexell/board.c b/arch/arm/mach-nexell/board.c
> index f0d258b71c..54a9d8c1f5 100644
> --- a/arch/arm/mach-nexell/board.c
> +++ b/arch/arm/mach-nexell/board.c
> @@ -5,9 +5,14 @@
> */
>
> #include <common.h>
> +#include <asm/io.h>
>
> DECLARE_GLOBAL_DATA_PTR;
>
> +#define NEXELL_PLLSETREG0 0xc0010008UL

Is this not in the DT?

Do you need the UL?