public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [GIT] Pull request: u-boot-dfu (30.11.2017)
Date: Thu, 30 Nov 2017 16:30:24 +0100	[thread overview]
Message-ID: <20171130163024.292a3671@jawa> (raw)
In-Reply-To: <520648e1-dc00-22ed-156c-f4cc97354deb@denx.de>

Hi Marek,

> On 11/30/2017 11:12 AM, Lukasz Majewski wrote:
> > Dear Marek,
> > 
> > The following changes since commit
> > d0b067b0effec202e62616c9c1e2ba8a90de1773:
> > 
> >   usb: r8a66597: convert wait loop to readw_poll_timeout
> > (2017-11-30 01:17:03 +0100)
> > 
> > are available in the git repository at:
> > 
> >   git://git.denx.de/u-boot-dfu.git 
> > 
> > for you to fetch changes up to
> > f8ae9831484ca741808dc4f430151aebf631dec1:
> > 
> >   rockchip: rk3288: enable rockusb support on rk3288 based device
> > (2017-11-30 11:09:30 +0100)
> > 
> > ----------------------------------------------------------------
> > Eddie Cai (4):
> >       usb: rockchip: add the rockusb gadget
> >       usb: rockchip: add rockusb command
> >       rockchip:usb: add a simple readme for rockusb
> >       rockchip: rk3288: enable rockusb support on rk3288 based
> > device  
> Sorry, NAK, these patches have at least checkpatch issues and maybe
> some more problems. Please review them again.

Ouch....

Thanks for spotting them.

I only run the buildtests on them.... without checkpatch.....

> 



Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171130/aeba4886/attachment.sig>

      reply	other threads:[~2017-11-30 15:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-23 11:31 [U-Boot] [GIT] Pull request: u-boot-dfu (23.11.2017) Lukasz Majewski
2017-11-23 11:57 ` Marek Vasut
2017-11-30 10:12 ` [U-Boot] [GIT] Pull request: u-boot-dfu (30.11.2017) Lukasz Majewski
2017-11-30 12:49   ` Marek Vasut
2017-11-30 15:30     ` Lukasz Majewski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171130163024.292a3671@jawa \
    --to=lukma@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox