From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Thu, 30 Nov 2017 11:38:59 -0500 Subject: [U-Boot] [U-Boot,v3,10/14] log: Add a test command In-Reply-To: References: <20171120223335.45852-11-sjg@chromium.org> <20171130033553.GA20815@bill-the-cat> Message-ID: <20171130163859.GH3587@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Nov 30, 2017 at 09:27:13AM -0700, Simon Glass wrote: > Hi Tom, > > On 29 November 2017 at 20:35, Tom Rini wrote: > > On Mon, Nov 20, 2017 at 03:33:31PM -0700, Simon Glass wrote: > > > >> Add a command which exercises the logging system. > >> > >> Signed-off-by: Simon Glass > >> Reviewed-by: Lukasz Majewski > > > > NAK. With clang-3.8 we see this (and many more): > > test/log/log_test.c:35:16: warning: implicit conversion from > > enumeration type 'enum uclass_id' to different enumeration type 'enum > > log_category_t' [-Wenum-conversion] > > UCLASS_MMC, UCLASS_SPI, LOGC_NONE, LOGC_END > > ^~~~~~~~~~ > > > > For nearly all instances of UCLASS_MMC and UCLASS_SPI in the code. > > That is unfortunate. I was really hoping to use the uclass as the > logging class. I'll have to add a cast or something like that, There were a bunch of other clang related warnings in this series too (I wasn't sure which patch, nor for certain it was this series until I dropped 'em all, after sending the email here). Can you please grab clang-3.8 (easy in Debian 9/Ubuntu 16.04 at least) and see what pops up over the whole series? Also, don't move up newer as, sigh, there's a bunch of other warnings showing up unrelated there and I haven't sat down and tried to figure any of those out. Thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: