From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC] CONFIG_DM_MMC should depend on CONFIG_MMC
Date: Sat, 2 Dec 2017 18:26:37 -0500 [thread overview]
Message-ID: <20171202232637.GZ3587@bill-the-cat> (raw)
In-Reply-To: <ea5bf929-1216-61bf-331a-2f5fcdf302c9@gmx.de>
On Sat, Dec 02, 2017 at 11:07:53AM +0100, Heinrich Schuchardt wrote:
> Hello Simon,
>
> do you remember reason why you chose that CONFIG_DM_MMC should not depend on
> CONFIG_MMC?
>
> [PATCH] dm: mmc: Add an MMC uclass
> e7ecf7cb5a6b873daf2d88daf03034d51fad4acc
>
> My gut feeling is that it should have that dependency like
> DM_USB depends on USB and DM_PCI depends PCI.
>
> The same question arises for DM_SCSI, DM_SERIAL where such a dependency is
> also missing.
>
> Furthermore shouldn't DM_MMC default to MMC && DM?
We cannot express this in Kconfig yet due to USB gadget stuff, iirc. I
think we had this discussion and root-causing over on imx6 maybe 2
months ago? Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171202/843618b6/attachment.sig>
prev parent reply other threads:[~2017-12-02 23:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-02 10:07 [U-Boot] [RFC] CONFIG_DM_MMC should depend on CONFIG_MMC Heinrich Schuchardt
2017-12-02 23:26 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171202232637.GZ3587@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox