From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Sat, 2 Dec 2017 18:26:37 -0500 Subject: [U-Boot] [RFC] CONFIG_DM_MMC should depend on CONFIG_MMC In-Reply-To: References: Message-ID: <20171202232637.GZ3587@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sat, Dec 02, 2017 at 11:07:53AM +0100, Heinrich Schuchardt wrote: > Hello Simon, > > do you remember reason why you chose that CONFIG_DM_MMC should not depend on > CONFIG_MMC? > > [PATCH] dm: mmc: Add an MMC uclass > e7ecf7cb5a6b873daf2d88daf03034d51fad4acc > > My gut feeling is that it should have that dependency like > DM_USB depends on USB and DM_PCI depends PCI. > > The same question arises for DM_SCSI, DM_SERIAL where such a dependency is > also missing. > > Furthermore shouldn't DM_MMC default to MMC && DM? We cannot express this in Kconfig yet due to USB gadget stuff, iirc. I think we had this discussion and root-causing over on imx6 maybe 2 months ago? Thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: