From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, PATCHv4] env: enable accessing the environment in an EXT4 partition
Date: Mon, 4 Dec 2017 10:23:29 -0500 [thread overview]
Message-ID: <20171204152329.GE3587@bill-the-cat> (raw)
In-Reply-To: <1511810360-8539-1-git-send-email-jorge.ramirez-ortiz@linaro.org>
On Mon, Nov 27, 2017 at 08:19:20PM +0100, Jorge Ramirez-Ortiz wrote:
> For example to store the environment in a file named "/uboot.env" in MMC
> "0", where partition "1" contains the EXT4 filesystem, the following
> configs should be added to the board's default config:
>
> CONFIG_ENV_IS_IN_EXT4=y
> CONFIG_ENV_EXT4_DEVICE_AND_PART="0:1"
> CONFIG_ENV_EXT4_FILE="/uboot.env"
> CONFIG_ENV_EXT4_INTERFACE="mmc"
> Reviewed-by: Tom Rini <trini@konsulko.com>
The code is fine, but you forgot a Signed-off-by line, so NAK without
one, sorry!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171204/07998703/attachment.sig>
next prev parent reply other threads:[~2017-12-04 15:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 19:19 [U-Boot] [PATCHv4] env: enable accessing the environment in an EXT4 partition Jorge Ramirez-Ortiz
2017-11-27 19:51 ` Tom Rini
2017-11-27 20:36 ` Jorge Ramirez
2017-12-04 15:23 ` Tom Rini [this message]
2017-12-04 18:03 ` [U-Boot] [U-Boot, PATCHv4] " Jorge Ramirez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171204152329.GE3587@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox