[U-Boot] [PATCH 04/14] env: Make the env save message a bit more explicit

Andre Przywara
2017-12-05T10:09:19Z

On 28/11/17 10:24, Maxime Ripard wrote:
> Since we'll soon have support for multiple environments, the environment
> saving message might end up being printed multiple times if the higher
> priority environment cannot be used.
>
> That might confuse the user, so let's make it explicit if the operation
> failed or not.
>
> Reviewed-by: Lukasz Majewski <lukma@denx.de>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Cheers,
Andre.

> ---
> env/env.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/env/env.c b/env/env.c
> index 673bfa6ba41b..1d13220aa79b 100644
> --- a/env/env.c
> +++ b/env/env.c
> @@ -131,8 +131,9 @@ int env_save(void)
> if (!drv->save)
> continue;
>
> - printf("Saving Environment to %s...\n", drv->name);
> + printf("Saving Environment to %s... ", drv->name);
> ret = drv->save();
> + printf("%s\n", ret ? "Failed" : "OK");
> if (!ret)
> return 0;
>
>