From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lothar =?UTF-8?B?V2HDn21hbm4=?= <LW@KARO-electronics.de>
Date: Mon, 11 Dec 2017 13:16:56 +0100
Subject: [U-Boot] [PATCH 2/2] common: Generic firmware loader for file
	system
In-Reply-To: <1512989626-4303-3-git-send-email-tien.fong.chee@intel.com>
References: <1512989626-4303-1-git-send-email-tien.fong.chee@intel.com>
 <1512989626-4303-3-git-send-email-tien.fong.chee@intel.com>
Message-ID: <20171211131656.5466c9e5@karo-electronics.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: quoted-printable
To: u-boot@lists.denx.de

Hi,

On Mon, 11 Dec 2017 18:53:46 +0800 tien.fong.chee at intel.com wrote:
> From: Tien Fong Chee <tien.fong.chee@intel.com>
>=20
[...}
> +/*
> + * Prepare firmware struct;
> + * return -ve if fail.
> + */
> +static int _request_firmware_prepare(struct firmware **firmware_p,
> +				     const char *name, void *dbuf,
> +				     size_t size, u32 offset)
> +{
> +	struct firmware *firmware =3D NULL;
> +	int ret =3D 0;
> +
> +	*firmware_p =3D NULL;
>
Sigh. This is useless...
> +	if (!name || name[0] =3D=3D '\0')
> +		ret =3D -EINVAL;
> +
unless you do a 'return -EINVAL' here!

> +	*firmware_p =3D firmware =3D calloc(1, sizeof(*firmware));
> +
> +	if (!firmware) {
> +		printf("%s: calloc(struct firmware) failed\n", __func__);
> +		return -ENOMEM;
> +	}
> +
> +	firmware->name =3D name;
> +	firmware->data =3D dbuf;
> +	firmware->size =3D size;
> +	firmware->offset =3D offset;
> +
> +	return ret;
> +}
> +


Lothar Wa=C3=9Fmann