* [U-Boot] [PATCH] sunxi: imply CONFIG_OF_LIBFDT_OVERLAY
@ 2017-12-13 8:46 Andre Heider
2017-12-13 8:51 ` Maxime Ripard
2017-12-19 11:42 ` Jagan Teki
0 siblings, 2 replies; 5+ messages in thread
From: Andre Heider @ 2017-12-13 8:46 UTC (permalink / raw)
To: u-boot
fdt overlay support is useful for all sunxi boards, enable per default
and remove it from sunxi defconfigs.
Signed-off-by: Andre Heider <a.heider@gmail.com>
---
Hi,
there're way too many sunxi boards so I'm not 100% sure this is the best
approach...
Are there boards where enabling this is definitely not desired?
Thanks,
Andre
arch/arm/Kconfig | 1 +
configs/CHIP_defconfig | 1 -
configs/CHIP_pro_defconfig | 1 -
3 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 73909952d0..25847b3aa1 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -715,6 +715,7 @@ config ARCH_SUNXI
select USE_TINY_PRINTF
imply CMD_GPT
imply FAT_WRITE
+ imply OF_LIBFDT_OVERLAY
imply PRE_CONSOLE_BUFFER
imply SPL_GPIO_SUPPORT
imply SPL_LIBCOMMON_SUPPORT
diff --git a/configs/CHIP_defconfig b/configs/CHIP_defconfig
index d057bee172..8b38ba450e 100644
--- a/configs/CHIP_defconfig
+++ b/configs/CHIP_defconfig
@@ -21,4 +21,3 @@ CONFIG_AXP_ALDO4_VOLT=3300
CONFIG_USB_EHCI_HCD=y
CONFIG_USB_MUSB_GADGET=y
CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
-CONFIG_OF_LIBFDT_OVERLAY=y
diff --git a/configs/CHIP_pro_defconfig b/configs/CHIP_pro_defconfig
index fa572eac57..089152e9ff 100644
--- a/configs/CHIP_pro_defconfig
+++ b/configs/CHIP_pro_defconfig
@@ -26,4 +26,3 @@ CONFIG_AXP_ALDO4_VOLT=3300
CONFIG_USB_EHCI_HCD=y
CONFIG_USB_MUSB_GADGET=y
CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
-CONFIG_OF_LIBFDT_OVERLAY=y
--
2.15.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] sunxi: imply CONFIG_OF_LIBFDT_OVERLAY
2017-12-13 8:46 [U-Boot] [PATCH] sunxi: imply CONFIG_OF_LIBFDT_OVERLAY Andre Heider
@ 2017-12-13 8:51 ` Maxime Ripard
2017-12-19 11:42 ` Jagan Teki
1 sibling, 0 replies; 5+ messages in thread
From: Maxime Ripard @ 2017-12-13 8:51 UTC (permalink / raw)
To: u-boot
On Wed, Dec 13, 2017 at 09:46:36AM +0100, Andre Heider wrote:
> fdt overlay support is useful for all sunxi boards, enable per default
> and remove it from sunxi defconfigs.
>
> Signed-off-by: Andre Heider <a.heider@gmail.com>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171213/a06cf8ca/attachment.sig>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] sunxi: imply CONFIG_OF_LIBFDT_OVERLAY
2017-12-13 8:46 [U-Boot] [PATCH] sunxi: imply CONFIG_OF_LIBFDT_OVERLAY Andre Heider
2017-12-13 8:51 ` Maxime Ripard
@ 2017-12-19 11:42 ` Jagan Teki
2017-12-19 12:51 ` Maxime Ripard
1 sibling, 1 reply; 5+ messages in thread
From: Jagan Teki @ 2017-12-19 11:42 UTC (permalink / raw)
To: u-boot
On Wed, Dec 13, 2017 at 2:16 PM, Andre Heider <a.heider@gmail.com> wrote:
> fdt overlay support is useful for all sunxi boards, enable per default
> and remove it from sunxi defconfigs.
>
> Signed-off-by: Andre Heider <a.heider@gmail.com>
> ---
>
> Hi,
>
> there're way too many sunxi boards so I'm not 100% sure this is the best
> approach...
>
> Are there boards where enabling this is definitely not desired?
>
> Thanks,
> Andre
>
> arch/arm/Kconfig | 1 +
> configs/CHIP_defconfig | 1 -
> configs/CHIP_pro_defconfig | 1 -
> 3 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 73909952d0..25847b3aa1 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -715,6 +715,7 @@ config ARCH_SUNXI
> select USE_TINY_PRINTF
> imply CMD_GPT
> imply FAT_WRITE
> + imply OF_LIBFDT_OVERLAY
It's increasing u-boot.itb size to 512KB (which is 508K earlier) and
in either case the size moves on env side where env start 0x88000
(504KB)
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] sunxi: imply CONFIG_OF_LIBFDT_OVERLAY
2017-12-19 11:42 ` Jagan Teki
@ 2017-12-19 12:51 ` Maxime Ripard
2017-12-19 15:31 ` Andre Heider
0 siblings, 1 reply; 5+ messages in thread
From: Maxime Ripard @ 2017-12-19 12:51 UTC (permalink / raw)
To: u-boot
On Tue, Dec 19, 2017 at 05:12:00PM +0530, Jagan Teki wrote:
> On Wed, Dec 13, 2017 at 2:16 PM, Andre Heider <a.heider@gmail.com> wrote:
> > fdt overlay support is useful for all sunxi boards, enable per default
> > and remove it from sunxi defconfigs.
> >
> > Signed-off-by: Andre Heider <a.heider@gmail.com>
> > ---
> >
> > Hi,
> >
> > there're way too many sunxi boards so I'm not 100% sure this is the best
> > approach...
> >
> > Are there boards where enabling this is definitely not desired?
> >
> > Thanks,
> > Andre
> >
> > arch/arm/Kconfig | 1 +
> > configs/CHIP_defconfig | 1 -
> > configs/CHIP_pro_defconfig | 1 -
> > 3 files changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> > index 73909952d0..25847b3aa1 100644
> > --- a/arch/arm/Kconfig
> > +++ b/arch/arm/Kconfig
> > @@ -715,6 +715,7 @@ config ARCH_SUNXI
> > select USE_TINY_PRINTF
> > imply CMD_GPT
> > imply FAT_WRITE
> > + imply OF_LIBFDT_OVERLAY
>
> It's increasing u-boot.itb size to 512KB (which is 508K earlier) and
> in either case the size moves on env side where env start 0x88000
> (504KB)
Right, so maybe we can make that conditional to ARM?
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171219/9555daca/attachment.sig>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] sunxi: imply CONFIG_OF_LIBFDT_OVERLAY
2017-12-19 12:51 ` Maxime Ripard
@ 2017-12-19 15:31 ` Andre Heider
0 siblings, 0 replies; 5+ messages in thread
From: Andre Heider @ 2017-12-19 15:31 UTC (permalink / raw)
To: u-boot
On 19/12/17 13:51, Maxime Ripard wrote:
> On Tue, Dec 19, 2017 at 05:12:00PM +0530, Jagan Teki wrote:
>> On Wed, Dec 13, 2017 at 2:16 PM, Andre Heider <a.heider@gmail.com> wrote:
>>> fdt overlay support is useful for all sunxi boards, enable per default
>>> and remove it from sunxi defconfigs.
>>>
>>> Signed-off-by: Andre Heider <a.heider@gmail.com>
>>> ---
>>>
>>> Hi,
>>>
>>> there're way too many sunxi boards so I'm not 100% sure this is the best
>>> approach...
>>>
>>> Are there boards where enabling this is definitely not desired?
>>>
>>> Thanks,
>>> Andre
>>>
>>> arch/arm/Kconfig | 1 +
>>> configs/CHIP_defconfig | 1 -
>>> configs/CHIP_pro_defconfig | 1 -
>>> 3 files changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>>> index 73909952d0..25847b3aa1 100644
>>> --- a/arch/arm/Kconfig
>>> +++ b/arch/arm/Kconfig
>>> @@ -715,6 +715,7 @@ config ARCH_SUNXI
>>> select USE_TINY_PRINTF
>>> imply CMD_GPT
>>> imply FAT_WRITE
>>> + imply OF_LIBFDT_OVERLAY
>>
>> It's increasing u-boot.itb size to 512KB (which is 508K earlier) and
>> in either case the size moves on env side where env start 0x88000
>> (504KB)
>
> Right, so maybe we can make that conditional to ARM?
>
> Maxime
>
From the 'we're out of space' thread:
...
> So, with FIT_ENABLE_SHA256_SUPPORT, LZMADEC, ISO_PARTITION and the
> overlay support, we're at 500kB.
>
> Again, tight, but under the limit.
...
If I understood correctly the issue will be solved without any requiring
changes to this patch.
Let me know if that is not the case.
Thanks,
Andre
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-12-19 15:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-13 8:46 [U-Boot] [PATCH] sunxi: imply CONFIG_OF_LIBFDT_OVERLAY Andre Heider
2017-12-13 8:51 ` Maxime Ripard
2017-12-19 11:42 ` Jagan Teki
2017-12-19 12:51 ` Maxime Ripard
2017-12-19 15:31 ` Andre Heider
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox