From: linux-kernel-dev at beckhoff.com <linux-kernel-dev@beckhoff.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 3/4] arm: imx: m53evk: remove usage of mx53_dram_size
Date: Mon, 18 Dec 2017 10:02:41 +0100 [thread overview]
Message-ID: <20171218090242.16527-4-linux-kernel-dev@beckhoff.com> (raw)
In-Reply-To: <20171218090242.16527-1-linux-kernel-dev@beckhoff.com>
From: Patrick Bruenn <p.bruenn@beckhoff.com>
Static variables are not available during board_init_f().
'static uint32_t mx53_dram_size[2];' was used in board specific
dram_init(), dram_init_banksize() and get_effective_memsize() to avoid
multiple calls to get_ram_size().
Reused dram initialization functions from arch/arm/mach-imx/mx5/mx53_dram.c
Signed-off-by: Patrick Bruenn <p.bruenn@beckhoff.com>
---
Changes in v2: None
Only compile tested with make m53evk_defconfig
---
arch/arm/mach-imx/mx5/Makefile | 1 +
board/aries/m53evk/m53evk.c | 39 ---------------------------------------
2 files changed, 1 insertion(+), 39 deletions(-)
diff --git a/arch/arm/mach-imx/mx5/Makefile b/arch/arm/mach-imx/mx5/Makefile
index 368cfde98b..2cc2cbc07a 100644
--- a/arch/arm/mach-imx/mx5/Makefile
+++ b/arch/arm/mach-imx/mx5/Makefile
@@ -11,4 +11,5 @@ obj-y := soc.o clock.o
obj-y += lowlevel_init.o
# common files for mx53 dram initialization
+obj-$(CONFIG_TARGET_M53EVK) += mx53_dram.o
obj-$(CONFIG_TARGET_MX53CX9020) += mx53_dram.o
diff --git a/board/aries/m53evk/m53evk.c b/board/aries/m53evk/m53evk.c
index ece8957aaf..a798d83376 100644
--- a/board/aries/m53evk/m53evk.c
+++ b/board/aries/m53evk/m53evk.c
@@ -31,45 +31,6 @@
DECLARE_GLOBAL_DATA_PTR;
-static uint32_t mx53_dram_size[2];
-
-phys_size_t get_effective_memsize(void)
-{
- /*
- * WARNING: We must override get_effective_memsize() function here
- * to report only the size of the first DRAM bank. This is to make
- * U-Boot relocator place U-Boot into valid memory, that is, at the
- * end of the first DRAM bank. If we did not override this function
- * like so, U-Boot would be placed at the address of the first DRAM
- * bank + total DRAM size - sizeof(uboot), which in the setup where
- * each DRAM bank contains 512MiB of DRAM would result in placing
- * U-Boot into invalid memory area close to the end of the first
- * DRAM bank.
- */
- return mx53_dram_size[0];
-}
-
-int dram_init(void)
-{
- mx53_dram_size[0] = get_ram_size((void *)PHYS_SDRAM_1, 1 << 30);
- mx53_dram_size[1] = get_ram_size((void *)PHYS_SDRAM_2, 1 << 30);
-
- gd->ram_size = mx53_dram_size[0] + mx53_dram_size[1];
-
- return 0;
-}
-
-int dram_init_banksize(void)
-{
- gd->bd->bi_dram[0].start = PHYS_SDRAM_1;
- gd->bd->bi_dram[0].size = mx53_dram_size[0];
-
- gd->bd->bi_dram[1].start = PHYS_SDRAM_2;
- gd->bd->bi_dram[1].size = mx53_dram_size[1];
-
- return 0;
-}
-
static void setup_iomux_uart(void)
{
static const iomux_v3_cfg_t uart_pads[] = {
--
2.11.0
next prev parent reply other threads:[~2017-12-18 9:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 9:02 [U-Boot] [PATCH v2 0/4] arm: imx53: remove usage of mx53_dram_size linux-kernel-dev at beckhoff.com
2017-12-18 9:02 ` [U-Boot] [PATCH v2 1/4] arm: imx: cx9020: " linux-kernel-dev at beckhoff.com
2017-12-18 9:02 ` [U-Boot] [PATCH v2 2/4] arm: imx: cx9020: move dram init into common place linux-kernel-dev at beckhoff.com
2017-12-18 9:02 ` linux-kernel-dev at beckhoff.com [this message]
2017-12-18 9:17 ` [U-Boot] [PATCH v2 3/4] arm: imx: m53evk: remove usage of mx53_dram_size Marek Vasut
2017-12-18 10:47 ` Patrick Brünn
2017-12-18 10:57 ` Marek Vasut
2017-12-18 11:40 ` Patrick Brünn
2017-12-18 11:52 ` Marek Vasut
2017-12-18 12:16 ` Patrick Brünn
2017-12-18 12:29 ` Marek Vasut
2017-12-19 4:28 ` Patrick Brünn
2017-12-19 11:18 ` Marek Vasut
2017-12-19 7:48 ` Patrick Brünn
2017-12-19 9:59 ` Lothar Waßmann
2017-12-18 9:02 ` [U-Boot] [PATCH v2 4/4] arm: imx: mx53loco: " linux-kernel-dev at beckhoff.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171218090242.16527-4-linux-kernel-dev@beckhoff.com \
--to=linux-kernel-dev@beckhoff.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox