[U-Boot] [PATCH v1 01/10] common: do not compile common fastboot code when building the SPL

Jean-Jacques Hiblot
2017-12-21T15:28:40Z

On 21/12/2017 15:46, Tom Rini wrote:
> On Thu, Dec 21, 2017 at 12:53:47PM +0100, Jean-Jacques Hiblot wrote:
>
>> This is not required as fastboot can't be started from SPL.
>>
>> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
>> ---
>>
>> common/Makefile | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/common/Makefile b/common/Makefile
>> index 1416620..c7bde23 100644
>> --- a/common/Makefile
>> +++ b/common/Makefile
>> @@ -109,6 +109,7 @@ obj-$(CONFIG_IO_TRACE) += iotrace.o
>> obj-y += memsize.o
>> obj-y += stdio.o
>>
>> +ifndef CONFIG_SPL_BUILD
>> # This option is not just y/n - it can have a numeric value
>> ifdef CONFIG_FASTBOOT_FLASH
>> obj-y += image-sparse.o
>> @@ -119,6 +120,7 @@ ifdef CONFIG_FASTBOOT_FLASH_NAND_DEV
>> obj-y += fb_nand.o
>> endif
>> endif
>> +endif
>>
>> ifdef CONFIG_CMD_EEPROM_LAYOUT
>> obj-y += eeprom/eeprom_field.o eeprom/eeprom_layout.o
> We don't need this as all of the code (and text) is discarded. Checked
> with am335x_evm_usbspl as that does set FASTBOOT. Thanks!
Yes but even if it is dropped out, it gets compiled. At this point in
the series it is okay, but a later patch will conditionally remove some
members from "struct mmc" and the compilation will break. Instead of
adding #ifdef, I opted for not compiling it.

JJ

>