From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] x86: Move commands from under arch/x86 to cmd/x86/
Date: Sat, 23 Dec 2017 07:42:03 -0500 [thread overview]
Message-ID: <20171223124203.GS7592@bill-the-cat> (raw)
In-Reply-To: <CAEUhbmU3_YbsWccFJsuT+-+BUAL0VASZc26Rx4NswTXubPfxyw@mail.gmail.com>
On Sat, Dec 23, 2017 at 07:07:00PM +0800, Bin Meng wrote:
> Hi Tom,
>
> On Sat, Dec 23, 2017 at 1:01 AM, Tom Rini <trini@konsulko.com> wrote:
> > We only need to compile and link these files when building for full
> > U-Boot. Move them to under cmd/x86/ to make sure they aren't linked in
> > and undiscarded due to u_boot_list_2_cmd_* being included).
> >
> > Cc: Bin Meng <bmeng.cn@gmail.com>
> > Signed-off-by: Tom Rini <trini@konsulko.com>
> > ---
> > arch/x86/lib/Makefile | 1 -
> > arch/x86/lib/cmd_mtrr.c | 139 -----------------------------------------
> > arch/x86/lib/fsp/Makefile | 1 -
> > arch/x86/lib/fsp/cmd_fsp.c | 152 ---------------------------------------------
> > cmd/Makefile | 2 +
> > cmd/x86/Makefile | 6 ++
> > cmd/x86/cmd_fsp.c | 152 +++++++++++++++++++++++++++++++++++++++++++++
>
> Drop the 'cmd_' prefix?
>
> > cmd/x86/cmd_mtrr.c | 139 +++++++++++++++++++++++++++++++++++++++++
>
> ditto
OK.
> > 8 files changed, 299 insertions(+), 293 deletions(-)
> > delete mode 100644 arch/x86/lib/cmd_mtrr.c
> > delete mode 100644 arch/x86/lib/fsp/cmd_fsp.c
> > create mode 100644 cmd/x86/Makefile
> > create mode 100644 cmd/x86/cmd_fsp.c
> > create mode 100644 cmd/x86/cmd_mtrr.c
>
> Looks the commit was not done via 'git mv'?
It was, but I didn't do git format-patch -M, I'll do that for v2.
Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171223/19b25e80/attachment.sig>
prev parent reply other threads:[~2017-12-23 12:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-22 17:01 [U-Boot] [PATCH] x86: Move commands from under arch/x86 to cmd/x86/ Tom Rini
2017-12-23 11:07 ` Bin Meng
2017-12-23 12:42 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171223124203.GS7592@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox