public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 8/9] spl: ram: Add support for fetching image position from control DT
Date: Thu, 28 Dec 2017 13:06:20 +0100	[thread overview]
Message-ID: <20171228120621.4039-9-marex@denx.de> (raw)
In-Reply-To: <20171228120621.4039-1-marex@denx.de>

Add support for fetching the image position in RAM from control DT
rather than hard-coding it. While doing so, return the return value
of spl_parse_header_image() to make it possible to test application
of DTOs on U-Boot's control DT.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
Cc: Simon Glass <sjg@chromium.org>
---
 common/spl/spl_ram.c | 21 ++++++++++++++++-----
 1 file changed, 16 insertions(+), 5 deletions(-)

diff --git a/common/spl/spl_ram.c b/common/spl/spl_ram.c
index fa8c768773..c88d09ba04 100644
--- a/common/spl/spl_ram.c
+++ b/common/spl/spl_ram.c
@@ -14,12 +14,14 @@
 #include <binman_sym.h>
 #include <mapmem.h>
 #include <spl.h>
-#include <libfdt.h>
+#include <fdtdec.h>
 
 #ifndef CONFIG_SPL_LOAD_FIT_ADDRESS
 # define CONFIG_SPL_LOAD_FIT_ADDRESS	0
 #endif
 
+DECLARE_GLOBAL_DATA_PTR;
+
 static ulong spl_ram_load_read(struct spl_load_info *load, ulong sector,
 			       ulong count, void *buf)
 {
@@ -33,7 +35,12 @@ static int spl_ram_load_image(struct spl_image_info *spl_image,
 			      struct spl_boot_device *bootdev)
 {
 	struct image_header *header;
+	unsigned image_offs;
 
+#if CONFIG_IS_ENABLED(OF_CONTROL) && !CONFIG_IS_ENABLED(OF_PLATDATA)
+	image_offs = fdtdec_get_config_int(gd->fdt_blob,
+					   "u-boot,spl-image-offset", 0);
+#endif
 	header = (struct image_header *)CONFIG_SPL_LOAD_FIT_ADDRESS;
 
 #if defined(CONFIG_SPL_DFU_SUPPORT)
@@ -48,7 +55,7 @@ static int spl_ram_load_image(struct spl_image_info *spl_image,
 		debug("Found FIT\n");
 		load.bl_len = 1;
 		load.read = spl_ram_load_read;
-		spl_load_simple_fit(spl_image, &load, 0, header);
+		return spl_load_simple_fit(spl_image, &load, 0, header);
 	} else {
 		ulong u_boot_pos = binman_sym(ulong, u_boot_any, pos);
 
@@ -64,12 +71,16 @@ static int spl_ram_load_image(struct spl_image_info *spl_image,
 			 * No binman support or no information. For now, fix it
 			 * to the address pointed to by U-Boot.
 			 */
-			u_boot_pos = CONFIG_SYS_TEXT_BASE -
-					sizeof(struct image_header);
+			if (image_offs)
+				u_boot_pos = image_offs;
+			else
+				u_boot_pos = CONFIG_SYS_TEXT_BASE -
+					     sizeof(struct image_u_boot_pos);
 		}
 		header = (struct image_header *)map_sysmem(u_boot_pos, 0);
 
-		spl_parse_image_header(spl_image, header);
+
+		return spl_parse_image_header(spl_image, header);
 	}
 
 	return 0;
-- 
2.15.0

  parent reply	other threads:[~2017-12-28 12:06 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-28 12:06 [U-Boot] [PATCH 0/9] spl: Add full fit and u-boot dto support Marek Vasut
2017-12-28 12:06 ` [U-Boot] [PATCH 1/9] fit: Fix CONFIG_FIT_SPL_PRINT Marek Vasut
2018-01-08  3:53   ` Simon Glass
2017-12-28 12:06 ` [U-Boot] [PATCH 2/9] fit: Add empty fit_print_contents() and fit_image_print() Marek Vasut
2018-01-08  3:53   ` Simon Glass
2017-12-28 12:06 ` [U-Boot] [PATCH 3/9] fit: Add standalone image type handling Marek Vasut
2018-01-08  3:53   ` Simon Glass
2017-12-28 12:06 ` [U-Boot] [PATCH 4/9] fit: Verify all configuration signatures Marek Vasut
2018-01-08  3:56   ` Simon Glass
2017-12-28 12:06 ` [U-Boot] [PATCH 5/9] spl: Add full fitImage support Marek Vasut
2017-12-28 14:21   ` Lukasz Majewski
2018-01-08  3:58   ` Simon Glass
2017-12-28 12:06 ` [U-Boot] [PATCH 6/9] spl: Add support for overlaying U-Boot DT Marek Vasut
2017-12-28 14:23   ` Lukasz Majewski
2018-01-08  4:20   ` Simon Glass
2017-12-28 12:06 ` [U-Boot] [PATCH 7/9] spl: Restart loading if load_image returns -EAGAIN Marek Vasut
2017-12-28 14:25   ` Lukasz Majewski
2017-12-31 17:37     ` Marek Vasut
2017-12-28 12:06 ` Marek Vasut [this message]
2017-12-28 14:27   ` [U-Boot] [PATCH 8/9] spl: ram: Add support for fetching image position from control DT Lukasz Majewski
2018-01-08  4:20   ` Simon Glass
2017-12-28 12:06 ` [U-Boot] [PATCH 9/9] spl: spi: " Marek Vasut
2017-12-28 14:29   ` Lukasz Majewski
2018-01-08  4:37     ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171228120621.4039-9-marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox