* [U-Boot] [PATCH] arm: mach-omap2: Remove secure certificate name printing
@ 2018-01-09 20:33 Andrew F. Davis
2018-01-19 21:14 ` [U-Boot] " Tom Rini
0 siblings, 1 reply; 2+ messages in thread
From: Andrew F. Davis @ 2018-01-09 20:33 UTC (permalink / raw)
To: u-boot
The signing certificate name is always 15 chars long, but need not be
null terminated. One solution is then to use printf precision modifiers
to only print this many chars ("%.15s"), but tiny printf does not support
this, so lets just drop printing the cert name for now.
Signed-off-by: Andrew F. Davis <afd@ti.com>
---
arch/arm/mach-omap2/sec-common.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm/mach-omap2/sec-common.c b/arch/arm/mach-omap2/sec-common.c
index 2630e7d316..e52c8526c7 100644
--- a/arch/arm/mach-omap2/sec-common.c
+++ b/arch/arm/mach-omap2/sec-common.c
@@ -168,16 +168,16 @@ auth_exit:
}
/*
- * Output notification of successful authentication as well the name of
- * the signing certificate used to re-assure the user that the secure
- * code is being processed as expected. However suppress any such log
- * output in case of building for SPL and booting via YMODEM. This is
- * done to avoid disturbing the YMODEM serial protocol transactions.
+ * Output notification of successful authentication to re-assure the
+ * user that the secure code is being processed as expected. However
+ * suppress any such log output in case of building for SPL and booting
+ * via YMODEM. This is done to avoid disturbing the YMODEM serial
+ * protocol transactions.
*/
if (!(IS_ENABLED(CONFIG_SPL_BUILD) &&
IS_ENABLED(CONFIG_SPL_YMODEM_SUPPORT) &&
spl_boot_device() == BOOT_DEVICE_UART))
- printf("Authentication passed: %s\n", (char *)sig_addr);
+ printf("Authentication passed\n");
return result;
}
--
2.15.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] arm: mach-omap2: Remove secure certificate name printing
2018-01-09 20:33 [U-Boot] [PATCH] arm: mach-omap2: Remove secure certificate name printing Andrew F. Davis
@ 2018-01-19 21:14 ` Tom Rini
0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2018-01-19 21:14 UTC (permalink / raw)
To: u-boot
On Tue, Jan 09, 2018 at 02:33:54PM -0600, Andrew F. Davis wrote:
> The signing certificate name is always 15 chars long, but need not be
> null terminated. One solution is then to use printf precision modifiers
> to only print this many chars ("%.15s"), but tiny printf does not support
> this, so lets just drop printing the cert name for now.
>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180119/f8e509d8/attachment.sig>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-19 21:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-09 20:33 [U-Boot] [PATCH] arm: mach-omap2: Remove secure certificate name printing Andrew F. Davis
2018-01-19 21:14 ` [U-Boot] " Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox