From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] BugFix: PXE Boot fails on old arm kernel with initrd without FDT
Date: Wed, 10 Jan 2018 08:05:27 -0500 [thread overview]
Message-ID: <20180110130527.GD2621@bill-the-cat> (raw)
In-Reply-To: <1889937.G0aEoS4ujg@neptun.jupiter.dom>
On Mon, Oct 30, 2017 at 02:37:17PM +0100, Sven Glodowski wrote:
> Hello,
>
> PXE/Extlinux boot fails on old Kernel which requires initrd but doesn't have FDT!
>
> sysboot loads initrd loaded into RAM, but system boots without initrd and hangs.
>
> Kernel:
> Linux odroid 3.8.13.30 #1 SMP PREEMPT Wed Feb 1 20:17:12 CET 2017 armv7l armv7l armv7l GNU/Linux
>
> Looking into [master]u-boot/cmd/pxe.c,
> function label_boot(cmd_tbl_t *cmdtp, struct pxe_label *label)
>
> Number of boot parameter initializing with 2
> 622: int bootm_argc = 2;
>
> Before calling boot_m / boot_z,
> number of boot parameters updated only if FTD is used!
>
> 783 if (!bootm_argv[3])
> 784 bootm_argv[3] = getenv("fdt_addr");
> 785
> 786 if (bootm_argv[3]) {
> 787 if (!bootm_argv[2])
> 788 bootm_argv[2] = "-";
> 789 bootm_argc = 4;
>
> Applying this patch, Number of boot parameters set to 3 if initrd loaded before.
>
This looks like a reasonable bugfix, thanks. But first, you forgot your
Signed-off-by line. And second, can you please condense your commit
message a bit? Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180110/25747914/attachment.sig>
prev parent reply other threads:[~2018-01-10 13:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-30 13:37 [U-Boot] [PATCH] BugFix: PXE Boot fails on old arm kernel with initrd without FDT Sven Glodowski
2018-01-10 13:05 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180110130527.GD2621@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox