[U-Boot] Pull request, u-boot-tegra/master

[Tom Rini <trini@konsulko.com>]

On Fri, Jan 12, 2018 at 10:37:06AM -0700, Tom Warren wrote:

> Tom,
> 
> Please pull u-boot-tegra/master into U-Boot/master. Thanks!
> 
> All Tegra builds are OK, and Stephen's automated test system reports that
> all tests pass.
> 
> The following changes since commit 373b9003410b44a1133060c2e63483b278fb476b:
> 
>   Merge git://git.denx.de/u-boot-sunxi (2018-01-11 14:14:19 -0500)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-tegra.git master
> 
> for you to fetch changes up to 5fed97af20da955625cc06563a725b49cebb99eb:
> 
>   Makefile: ensure DTB doesn't overflow into initial stack (2018-01-12
> 10:12:32 -0700)
> 

Applied to u-boot/master, thanks!

But please note the following checkpatch.pl issues that should be looked
into and possibly addressed:

CHECK: Macro argument reuse 'data' - possible side-effects?
#93: FILE: arch/arm/cpu/armv8/linux-kernel-image-header-vars.h:36:
+#define DATA_LE32(data)				\
+	((((data) & 0x000000ff) << 24) |	\
+	 (((data) & 0x0000ff00) << 8)  |	\
+	 (((data) & 0x00ff0000) >> 8)  |	\
+	 (((data) & 0xff000000) >> 24))

CHECK: Macro argument reuse 'data' - possible side-effects?
#102: FILE: arch/arm/cpu/armv8/linux-kernel-image-header-vars.h:45:
+#define DEFINE_IMAGE_LE64(sym, data)				\
+	sym##_lo32 = DATA_LE32((data) & 0xffffffff);		\
+	sym##_hi32 = DATA_LE32((data) >> 32)

CHECK: Macro argument reuse 'a' - possible side-effects?
#106: FILE: arch/arm/cpu/armv8/linux-kernel-image-header-vars.h:49:
+#define __MAX(a, b)		(((a) > (b)) ? (a) : (b))

CHECK: Macro argument reuse 'b' - possible side-effects?
#106: FILE: arch/arm/cpu/armv8/linux-kernel-image-header-vars.h:49:
+#define __MAX(a, b)		(((a) > (b)) ? (a) : (b))

WARNING: macros should not use a trailing semicolon
#138: FILE: arch/arm/cpu/armv8/linux-kernel-image-header-vars.h:81:
+#define HEAD_SYMBOLS						\
+	DEFINE_IMAGE_LE64(_kernel_size_le, __MEM_USAGE);	\
+	DEFINE_IMAGE_LE64(_kernel_offset_le, TEXT_OFFSET);	\
+	DEFINE_IMAGE_LE64(_kernel_flags_le, __HEAD_FLAGS);

ERROR: spaces required around that ':' (ctx:VxE)
#213: FILE: arch/arm/include/asm/boot0-linux-kernel-header.h:36:
+_start:
       ^

WARNING: line over 80 characters
#217: FILE: arch/arm/include/asm/boot0-linux-kernel-header.h:40:
+	b	reset				/* branch to kernel start, magic */

WARNING: line over 80 characters
#219: FILE: arch/arm/include/asm/boot0-linux-kernel-header.h:42:
+	le64sym	_kernel_offset_le		/* Image load offset from start of RAM, little-endian */

WARNING: line over 80 characters
#220: FILE: arch/arm/include/asm/boot0-linux-kernel-header.h:43:
+	le64sym	_kernel_size_le			/* Effective size of kernel image, little-endian */

WARNING: line over 80 characters
#221: FILE: arch/arm/include/asm/boot0-linux-kernel-header.h:44:
+	le64sym	_kernel_flags_le		/* Informative flags, little-endian */

total: 1 errors, 6 warnings, 4 checks, 176 lines checked
ERROR: space required after that close brace '}'
#44: FILE: arch/arm/mach-tegra/tegra186/nvtboot_mem.c:32:
+} ram_banks[CONFIG_NR_DRAM_BANKS] = {{1}};

total: 1 errors, 0 warnings, 0 checks, 48 lines checked
WARNING: externs should be avoided in .c files
#58: FILE: arch/arm/mach-tegra/tegra186/nvtboot_mem.c:32:
+extern struct mm_region tegra_mem_map[];

total: 0 errors, 1 warnings, 0 checks, 138 lines checked
WARNING: externs should be avoided in .c files
#53: FILE: arch/arm/mach-tegra/tegra186/nvtboot_board.c:29:
+extern struct mm_region tegra_mem_map[];

total: 0 errors, 1 warnings, 0 checks, 286 lines checked

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180115/97dfc355/attachment.sig>