public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] arm: mach-omap2: Pass args to secure ROM in SRAM in SPL
@ 2018-01-16 20:25 Andrew F. Davis
  2018-01-28 18:52 ` [U-Boot] " Tom Rini
  0 siblings, 1 reply; 2+ messages in thread
From: Andrew F. Davis @ 2018-01-16 20:25 UTC (permalink / raw)
  To: u-boot

When in early SPL we make some secure ROM calls that can effect
DRAM, due to this it is more stable to store the args for these
calls in SRAM, but uninitialized and zero'd globals are placed
in BSS, located in DRAM. Force our args into the data section
which is in SRAM during SPL.

Signed-off-by: Andrew F. Davis <afd@ti.com>
---
 arch/arm/mach-omap2/sec-common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-omap2/sec-common.c b/arch/arm/mach-omap2/sec-common.c
index 2630e7d316..1906a126cf 100644
--- a/arch/arm/mach-omap2/sec-common.c
+++ b/arch/arm/mach-omap2/sec-common.c
@@ -56,7 +56,7 @@ struct ppa_tee_load_info {
 	u32 tee_arg0;          /* argument to TEE jump function, in r0 */
 };
 
-static uint32_t secure_rom_call_args[5] __aligned(ARCH_DMA_MINALIGN);
+static uint32_t secure_rom_call_args[5] __aligned(ARCH_DMA_MINALIGN) __section(".data");
 
 u32 secure_rom_call(u32 service, u32 proc_id, u32 flag, ...)
 {
-- 
2.15.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [U-Boot] arm: mach-omap2: Pass args to secure ROM in SRAM in SPL
  2018-01-16 20:25 [U-Boot] [PATCH] arm: mach-omap2: Pass args to secure ROM in SRAM in SPL Andrew F. Davis
@ 2018-01-28 18:52 ` Tom Rini
  0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2018-01-28 18:52 UTC (permalink / raw)
  To: u-boot

On Tue, Jan 16, 2018 at 02:25:48PM -0600, Andrew F. Davis wrote:

> When in early SPL we make some secure ROM calls that can effect
> DRAM, due to this it is more stable to store the args for these
> calls in SRAM, but uninitialized and zero'd globals are placed
> in BSS, located in DRAM. Force our args into the data section
> which is in SRAM during SPL.
> 
> Signed-off-by: Andrew F. Davis <afd@ti.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180128/6904b904/attachment.sig>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-01-28 18:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-16 20:25 [U-Boot] [PATCH] arm: mach-omap2: Pass args to secure ROM in SRAM in SPL Andrew F. Davis
2018-01-28 18:52 ` [U-Boot] " Tom Rini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox